feature/with url #3212
Merged
feature/with url #3212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
|
Kudos, SonarCloud Quality Gate passed! |
samwelkanda
reviewed
Aug 29, 2023
andrueastman
approved these changes
Aug 29, 2023
samwelkanda
approved these changes
Aug 29, 2023
|
Thanks for the fix @samwelkanda! |
This was referenced Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3199
@Ndiritu and @SilasKenneth to check the PHP changes
@samwelkanda to check the python changes. Also I noticed an issue with the indent that seems to predate my changes. Can you look at it?
This will greatly simplify the delta link pattern so maybe we shuold review the code samples @andrueastman @rkodev