Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding API review docs for ScrollPresenter and ScrollView controls #7245

Merged
merged 6 commits into from
Apr 28, 2023
Merged

Adding API review docs for ScrollPresenter and ScrollView controls #7245

merged 6 commits into from
Apr 28, 2023

Conversation

RBrid
Copy link
Contributor

@RBrid RBrid commented Jun 15, 2022

Draft PR for ScrollPresenter/ScrollView API review.

@RBrid RBrid self-assigned this Jun 15, 2022
@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Jun 15, 2022
MikeHillberg
MikeHillberg reviewed Jun 16, 2022
View reviewed changes
specs/ScrollingControls/ScrollPresenter.md Outdated Show resolved Hide resolved
specs/ScrollingControls/ScrollPresenter.md Outdated Show resolved Hide resolved
specs/ScrollingControls/ScrollPresenter.md Show resolved Hide resolved
specs/ScrollingControls/ScrollPresenter.md Outdated Show resolved Hide resolved
specs/ScrollingControls/ScrollPresenter.md Show resolved Hide resolved
specs/ScrollingControls/ScrollPresenter.md Outdated Show resolved Hide resolved
specs/ScrollingControls/ScrollPresenter.md Outdated Show resolved Hide resolved
specs/ScrollingControls/ScrollPresenter.md Show resolved Hide resolved
specs/ScrollingControls/ScrollPresenter.md Show resolved Hide resolved
specs/ScrollingControls/ScrollPresenter.md Outdated Show resolved Hide resolved
@ojhad ojhad added team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Jun 22, 2022
MikeHillberg
MikeHillberg reviewed Jun 28, 2022
View reviewed changes
specs/ScrollingControls/ScrollPresenter.md Show resolved Hide resolved
specs/ScrollingControls/ScrollPresenter.md Show resolved Hide resolved
specs/ScrollingControls/ScrollPresenter.md Outdated Show resolved Hide resolved
specs/ScrollingControls/ScrollPresenter.md Show resolved Hide resolved
specs/ScrollingControls/ScrollPresenter.md Show resolved Hide resolved
specs/ScrollingControls/ScrollPresenter.md Outdated Show resolved Hide resolved
specs/ScrollingControls/ScrollPresenter.md Outdated Show resolved Hide resolved
specs/ScrollingControls/ScrollPresenter.md Show resolved Hide resolved
specs/ScrollingControls/ScrollPresenter.md Outdated Show resolved Hide resolved
specs/ScrollingControls/ScrollPresenter.md Show resolved Hide resolved
MikeHillberg
MikeHillberg reviewed Jun 29, 2022
View reviewed changes
specs/ScrollingControls/ScrollPresenter.md Show resolved Hide resolved
specs/ScrollingControls/ScrollPresenter.md Show resolved Hide resolved
specs/ScrollingControls/ScrollPresenter.md Show resolved Hide resolved
specs/ScrollingControls/ScrollPresenter.md Show resolved Hide resolved
specs/ScrollingControls/ScrollPresenter.md Show resolved Hide resolved
specs/ScrollingControls/ScrollPresenter.md Show resolved Hide resolved
specs/ScrollingControls/ScrollPresenter.md Show resolved Hide resolved
specs/ScrollingControls/ScrollPresenter.md Show resolved Hide resolved
specs/ScrollingControls/ScrollPresenter.md Show resolved Hide resolved
specs/ScrollingControls/ScrollPresenter.md Show resolved Hide resolved
@bpulliam bpulliam added the documentation An issue with existing documentation or a request for documenation of a new topic label Nov 16, 2022
@robloo robloo mentioned this pull request Mar 28, 2023
Merged
@RBrid RBrid marked this pull request as ready for review April 28, 2023 20:00
@RBrid
Copy link
Contributor Author

RBrid commented Apr 28, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kmahone
Copy link
Member

kmahone commented Apr 28, 2023

@RBrid I see that the WinUI-PR run for this PR is doing a full build and test against this change. It is supposed to detect when a PR is only changing markdown and images and skip the build and test jobs. This broke with my recent change. Fix is here: #8443

@RBrid RBrid merged commit 872370c into main Apr 28, 2023
@RBrid RBrid deleted the user/regisb/ScrollingControlsSpecs1 branch April 28, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeHillberg MikeHillberg MikeHillberg left review comments

@ranjeshj ranjeshj ranjeshj approved these changes

Assignees

@RBrid RBrid

Labels
area-Scrolling documentation An issue with existing documentation or a request for documenation of a new topic SpecInReview team-Controls Issue for the Controls team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@RBrid @kmahone @MikeHillberg @ranjeshj @ojhad @bpulliam