Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed connection retry behavior when connectRetryCount is set to a value greater than 1 #2513

Merged
merged 31 commits into from
Nov 7, 2024

Conversation

Jeffery-Wasty
Copy link
Contributor

@Jeffery-Wasty Jeffery-Wasty commented Sep 18, 2024

Fixes the following issues:

  • We attempt one too many connection retries.
    • This is resolved by the change in SQLServerConnection::1997
  • We wait between the initial connection attempt, and the first retry attempt, when we shouldn't.
    • This is resolved by SQLServerConnection::2030 - 2031

@Jeffery-Wasty Jeffery-Wasty added this to the 12.9.0 milestone Sep 19, 2024
@Jeffery-Wasty Jeffery-Wasty self-assigned this Sep 19, 2024
@microsoft microsoft deleted a comment from codecov bot Sep 19, 2024
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.87%. Comparing base (3be298f) to head (ac63871).
Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2513      +/-   ##
============================================
+ Coverage     50.64%   50.87%   +0.23%     
- Complexity     3821     3887      +66     
============================================
  Files           145      147       +2     
  Lines         33133    33369     +236     
  Branches       5558     5593      +35     
============================================
+ Hits          16779    16978     +199     
- Misses        13951    13985      +34     
- Partials       2403     2406       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jeffery-Wasty Jeffery-Wasty marked this pull request as ready for review September 20, 2024 00:38
@Jeffery-Wasty Jeffery-Wasty modified the milestones: 12.9.0, 12.9.1 Nov 12, 2024
@lilgreenbird lilgreenbird changed the title Fix retries when connectRetryCount is set to 1 or greater Fixed connection retry behavior when connectRetryCount is set to a value greater than 1 [ Nov 20, 2024
@lilgreenbird lilgreenbird changed the title Fixed connection retry behavior when connectRetryCount is set to a value greater than 1 [ Fixed connection retry behavior when connectRetryCount is set to a value greater than 1 Nov 20, 2024
@Jeffery-Wasty Jeffery-Wasty deleted the connRetryFix branch November 20, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed/Merged PRs
Development

Successfully merging this pull request may close these issues.

4 participants