Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-pty is causing problems on ARM Systems beacuase glibc_2.28 dependency #428

Closed
Misery42 opened this issue Sep 11, 2020 · 9 comments · Fixed by microsoft/vscode#106656

Comments

@Misery42
Copy link

Environment details

OS and Version: Remote System is running
PRETTY_NAME="Raspbian GNU/Linux 9 (stretch)"
NAME="Raspbian GNU/Linux"
VERSION_ID="9"
VERSION="9 (stretch)"
VERSION_CODENAME=stretch
ID=raspbian
ID_LIKE=debian
HOME_URL="http://www.raspbian.org/"
SUPPORT_URL="http://www.raspbian.org/RaspbianForums"
BUG_REPORT_URL="http://www.raspbian.org/RaspbianBugs"

  • node-pty version: 0.10.0-beta17

Issue description

microsoft/vscode-cpptools#6116

@Tyriar
Copy link
Member

Tyriar commented Sep 11, 2020

@joaomoreno any ideas on what needs to happen here?

@sean-mcmanus
Copy link

sean-mcmanus commented Sep 11, 2020

FYI, our C/C++ extension for ARM builds on Ubuntu 18 core (with Ubuntu 16 packages), which allows us to have a glibc 2.17 dependency instead of the 2.28 one that would occur by building on Ubuntu 20 or Debian 10. It's possible your build machine got updated to a new OS and took the higher 2.28 dependency.

Since Ubuntu 18 and Debian 9 only support 2.27 (2.24 for Debian), and usage of Ubuntu 18 and Debian 9 are still significant, the 2.28 dependency is too high (see microsoft/vscode-cpptools#5993 ).

Our goal was to meet the 2.24/2.27 glibc dependency and drop Ubuntu 16, Debian 8, and CentOS 7, which had low usage, but we got support for those older OS's "for free" due to the usage of the Ubuntu 16 packages.

By "Ubuntu 16 package", I mean the g++ libraries that we use as our sysroot when building.

@Misery42
Copy link
Author

Using VS Code 1.49.0 solves the problem for me so far.

my newest os build has:

sudo dpkg -l | grep libc6
ii libc6:armhf 2.24-11+deb9u4 armhf GNU C Library: Shared libraries
ii libc6-dbg:armhf 2.24-11+deb9u4 armhf GNU C Library: detached debugging symbols
ii libc6-dev:armhf 2.24-11+deb9u4 armhf GNU C Library: Development Libraries and Header Files

@sean-mcmanus
Copy link

Our telemetry indicates that 46% of our ARM users would be impacted by this VS Code 1.50.0-insiders regression, so they would be stuck on VS Code 1.49.0 until they upgraded their OS.

@Tyriar
Copy link
Member

Tyriar commented Sep 11, 2020

@deepak1556 is this related to the Electron update?

@deepak1556
Copy link
Contributor

Not related to electron update, this comes from @joaomoreno recent work for arm microsoft/vscode#106289 , the build container was updated to use debian buster which uses glibc 2.28

@cheesefinger
Copy link

+1 having the same problem.

@Tyriar
Copy link
Member

Tyriar commented Sep 14, 2020

@deepak1556 our regular build container for all of VS Code? Won't that break support for Ubuntu 14/16/18 too?

@joaomoreno
Copy link
Member

Yeah I definitely changed the base docker images for the ARM server bits and decided to go with Debian buster. I am in the process to switch back to stretch, tomorrow's builds should already go back to the previous glibc version. Will update it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants