Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot associate the IsReleaseBuild to Nuget DML pipeline #14660

Closed
rui-ren opened this issue Feb 10, 2023 · 3 comments
Closed

Cannot associate the IsReleaseBuild to Nuget DML pipeline #14660

rui-ren opened this issue Feb 10, 2023 · 3 comments
Labels
ep:DML issues related to the DirectML execution provider

Comments

@rui-ren
Copy link
Contributor

rui-ren commented Feb 10, 2023

Describe the issue

When generating the release package for Nuget DML, the IsReleaseBuild flag is invalid for Nuget DML.

MicrosoftTeams-image

The release package will still have dev-*** tag.

To reproduce

Try this pipeline https://aiinfra.visualstudio.com/Lotus/_build?definitionId=940&_a=summary

Urgency

Not urgent

Platform

Web Browser

OS Version


ONNX Runtime Installation

Other / Unknown

ONNX Runtime Version or Commit ID

release

ONNX Runtime API

Python

Architecture

X64

Execution Provider

Other / Unknown

Execution Provider Library Version

No response

@github-actions github-actions bot added the ep:DML issues related to the DirectML execution provider label Feb 10, 2023
@rui-ren
Copy link
Contributor Author

rui-ren commented Feb 11, 2023

Here is a fix #13417 ,

but did not get into main branch. Will do cherry-pick and test it. Thanks

@fdwr
Copy link
Contributor

fdwr commented Feb 13, 2023

@rui-ren Appears this is the pertinent cherry-pick: #14662

@rui-ren
Copy link
Contributor Author

rui-ren commented Feb 14, 2023

issue got fix by #14662. Close this ticket.

@rui-ren rui-ren closed this as completed Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ep:DML issues related to the DirectML execution provider
Projects
None yet
Development

No branches or pull requests

2 participants