From 8fed0b33195a63d3505c69993bbf51db6bd2c47d Mon Sep 17 00:00:00 2001 From: Andrey Lushnikov Date: Mon, 2 Nov 2020 21:00:37 -0800 Subject: [PATCH] feat(firefox): roll Firefox to r1200 (#4316) This roll includes: - fix for the firefox flakiness related to popups - fix for browser context closing with beforeunload events References #4021 --- browsers.json | 2 +- test/beforeunload.spec.ts | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/browsers.json b/browsers.json index 3c623509f92dc..206769a638477 100644 --- a/browsers.json +++ b/browsers.json @@ -8,7 +8,7 @@ }, { "name": "firefox", - "revision": "1198", + "revision": "1200", "download": true }, { diff --git a/test/beforeunload.spec.ts b/test/beforeunload.spec.ts index 39fd4a44bda6a..0a258a22bf23a 100644 --- a/test/beforeunload.spec.ts +++ b/test/beforeunload.spec.ts @@ -29,7 +29,6 @@ it('should close browser with beforeunload page', (test, {browserName}) => { }); it('should close browsercontext with beforeunload page', (test, {browserName}) => { - test.fixme(browserName === 'firefox'); }, async ({server, contextFactory }) => { const browserContext = await contextFactory(); const page = await browserContext.newPage(); @@ -75,7 +74,6 @@ it('should run beforeunload if asked for', async ({context, server, isChromium, it('should access page after beforeunload', (test, { browserName }) => { test.fixme(browserName === 'chromium'); - test.fixme(browserName === 'firefox'); }, async ({contextFactory, server}) => { const context = await contextFactory(); const page = await context.newPage();