[BUG] networkidle while requests in progress

[tuukka]

Context:

• Playwright Version: 1.7.0
• Operating System: Linux
• Node.js version: 12.19
• Browser: Chromium

Code Snippet

const { chromium } = require("playwright");

(async () => {
  const browser = await chromium.launch();
  const page = await browser.newPage();

  let inProgress = 0;
  
  page.on('request', request => {
    console.log(Date.now(), '>>', request.method(), request.url());
    inProgress++;
  });
  page.on('response', response => {
    console.log(Date.now(), '<<', response.status(), response.url());
    inProgress--;
  });
  
  console.log(Date.now(), "waiting for page");
  await page.goto("http://localhost:3000/", {
    //    waitUntil: "networkidle",
  });
  
  console.log(Date.now(), "waiting 500");
  await page.waitForTimeout(500);

  console.log(Date.now(), "waiting for networkidle");
  await page.waitForLoadState("networkidle");

  console.log(Date.now(), "Requests in progress after networkidle:", inProgress);

  await browser.close();
})();

Describe the bug

The networkidle event can fire even though requests are in progress (but are taking longer, for example). I would expect the event to fire after 500ms of no requests in progress. (The example script should always finish with inProgress === 0 but doesn't.)

I was not able to reproduce this during page load with waitUntil: "networkidle", so perhaps the logic is different there?

[tuukka]

Sorry, found #2515 and this seems to be a duplicate: networkidle is not supposed to wait for requests to finish.