Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename 'uwp' platform to 'windows' #2745

Closed
kmelmon opened this issue Jul 9, 2019 · 0 comments · Fixed by #2922
Closed

Rename 'uwp' platform to 'windows' #2745

kmelmon opened this issue Jul 9, 2019 · 0 comments · Fixed by #2922
Assignees
@acoates-ms
Labels
enhancement
Milestone
IGNITE (vNext M3)

Comments

@kmelmon
Copy link
Contributor

kmelmon commented Jul 9, 2019 •
edited
Loading

Proposal: Rename 'uwp' platform to 'windows'

Rename uwp platform to windows

Summary

currently vnext has a "platform" attribute of 'uwp'. This was done to avoid any possible naming conflicts with current, which currently uses a platform of 'windows'. There really wasn't any technical reason for this and it's now becoming clear that 'windows' should be the platform name. This issue is tracking doing the rename.

Motivation

Basic example

Open Questions
@ghost ghost added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Jul 9, 2019
@kmelmon kmelmon changed the title [PROPOSAL]: Your feature request [PROPOSAL]: Rename 'uwp' platform to 'windows' Jul 9, 2019
@harinikmsft harinikmsft added this to the vNext Milestone 3 milestone Jul 9, 2019
@harinikmsft harinikmsft removed the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Jul 9, 2019
@kmelmon kmelmon assigned licanhua and unassigned marlenecota Jul 16, 2019
@kmelmon kmelmon mentioned this issue Aug 2, 2019
Closed
@chrisglein chrisglein changed the title [PROPOSAL]: Rename 'uwp' platform to 'windows' Rename 'uwp' platform to 'windows' Aug 10, 2019
@acoates-ms acoates-ms assigned acoates-ms and unassigned licanhua Aug 12, 2019
@acoates-ms acoates-ms mentioned this issue Aug 12, 2019
Merged
@ghost ghost closed this as completed in #2922 Aug 12, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acoates-ms acoates-ms

Labels
enhancement
Projects
None yet
Milestone
IGNITE (vNext M3)
Development

Successfully merging a pull request may close this issue.

Rename platform uwp->windows acoates-ms/react-native-windows
5 participants
@marlenecota @licanhua @harinikmsft @acoates-ms @kmelmon