Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VS Code] Change the CLI bundle name to index.bundle #2901

Closed
harinikmsft opened this issue Aug 7, 2019 · 1 comment · Fixed by #3099
Closed

[VS Code] Change the CLI bundle name to index.bundle #2901

harinikmsft opened this issue Aug 7, 2019 · 1 comment · Fixed by #3099
Assignees
@savatia
Labels
Area: CLI Area: Debug Infrastructure bug
Milestone
IGNITE (vNext M3)

Comments

@harinikmsft
Copy link
Contributor

This is needed to complete #2876 .

The decision here is to rename the bundle that is being generated through the CLI to index.bundle to match current as well as iOS/Android instead of the "app.bundle" name that it does today.
@ghost ghost added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Aug 7, 2019
@harinikmsft harinikmsft added this to the vNext Milestone 3 milestone Aug 7, 2019
@harinikmsft harinikmsft removed the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Aug 7, 2019
@kmelmon
Copy link
Contributor

kmelmon commented Aug 29, 2019

@savatia we think we still need to implement this for pre-warming to work, and to be consistent with the CLI on other platforms.

@kmelmon kmelmon mentioned this issue Aug 29, 2019
Closed
@savatia savatia mentioned this issue Sep 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@savatia savatia

Labels
Area: CLI Area: Debug Infrastructure bug
Projects
None yet
Milestone
IGNITE (vNext M3)
Development

Successfully merging a pull request may close this issue.

Change the CLI bundle name index.bundle (vnext) savatia/react-native-windows
4 participants
@savatia @harinikmsft @chrisglein @kmelmon