You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
/// <summary>/// The outgoing proxy request. All field are initialized except for the 'RequestUri' and optionally headers./// If no value is provided then the 'RequestUri' will be initialized using the updated 'DestinationPrefix',/// 'Path', and 'Query' properties after the transforms have run. The headers will be copied later when/// applying header transforms./// </summary>publicHttpRequestMessageProxyRequest{get;init;}=default!;
but DestinationPrefix cannot be changed:
/// <summary>/// The URI prefix for the proxy request. This includes the scheme and host and can optionally include a/// port and path base. The 'Path' and 'Query' properties will be appended to this after the transforms have run./// </summary>publicstringDestinationPrefix{get;init;}=default!;
Question
Is this a bug in the code or the comment?
The text was updated successfully, but these errors were encountered:
I guess we could make DestinationPrefix mutable since you can already override it via RequestUri. Careful though, changing the destination prefix at this point can mess up load balancing, health checks, etc. if the proxy is attributing state from one prefix to another host.
LOL! I am already overriding it via RequestUri and it is a bit fiddly. Updating DestinationPrefix is much cleaner and simpler, albeit with the riders you pointed out.
Could we make it mutable with some suitable warnings in the comments?
Describe the bug
commit: 527fafe
Comments in RequestTransformContext suggest that
DestinationPrefix
is able to be updated:but
DestinationPrefix
cannot be changed:Question
Is this a bug in the code or the comment?
The text was updated successfully, but these errors were encountered: