[rush] MaxListenersExceeded when trying to bump to Rush v5.147.1

[aramissennyeydd]

Summary

I'm trying to upgrade from 5.141.3 to 5.147.1 and noticing a bunch of (node:7835) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 error listeners added to [TLSSocket]. Use emitter.setMaxListeners() to increase limit messages in the logs in CI. Possibly related to #5027 as we are using the HTTP build cache plugin.

Repro steps

Expected result: No error message emitted.

Actual result:
This is especially noticeable for cobuild agents that are waiting on other agents to finish work.

==[ @company/heft-custom-plugin (phase) ]====================[ 51 of 1112 ]==
(node:7835) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 error listeners added to [TLSSocket]. Use emitter.setMaxListeners() to increase limit
(node:7835) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 error listeners added to [TLSSocket]. Use emitter.setMaxListeners() to increase limit
(node:7835) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 error listeners added to [TLSSocket]. Use emitter.setMaxListeners() to increase limit
(node:7835) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 error listeners added to [TLSSocket]. Use emitter.setMaxListeners() to increase limit
(node:7835) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 error listeners added to [TLSSocket]. Use emitter.setMaxListeners() to increase limit
(node:7835) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 error listeners added to [TLSSocket]. Use emitter.setMaxListeners() to increase limit
(node:7835) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 error listeners added to [TLSSocket]. Use emitter.setMaxListeners() to increase limit
(node:7835) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 error listeners added to [TLSSocket]. Use emitter.setMaxListeners() to increase limit
(node:7835) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 error listeners added to [TLSSocket]. Use emitter.setMaxListeners() to increase limit
(node:7835) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 error listeners added to [TLSSocket]. Use emitter.setMaxListeners() to increase limit
(node:7835) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 error listeners added to [TLSSocket]. Use emitter.setMaxListeners() to increase limit
(node:7835) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 error listeners added to [TLSSocket]. Use emitter.setMaxListeners() to increase limit

Details

Glancing through the PR that added the WebClient, it may be this line, https://github.com/microsoft/rushstack/pull/5031/files#diff-8df196227043924adc8887e26f2224e47811b41b87cc5d9824fd6431b9233f71R202-R209. Our build cache config is pretty standard, we use Artifactory to store assets to,

{
  "$schema": "https://developer.microsoft.com/json-schemas/rush/v5/build-cache.schema.json",
  "buildCacheEnabled": true,
  "cacheEntryNamePattern": "[projectName:normalize]-[phaseName:normalize]-[hash]",

  "cacheProvider": "http",

  "httpConfiguration": {
    "url": "https://company.jfrog.io/artifactory/rush-cache-local",
    "isCacheWriteAllowed": false
  }
}

Standard questions

Please answer these questions to help us investigate your issue more quickly:

Question	Answer
@microsoft/rush globally installed version?	5.147.1
rushVersion from rush.json?	5.147.1
useWorkspaces from rush.json?	true
Operating system?	Linux
Would you consider contributing a PR?	Yes
Node.js version (node -v)?	20.12.2

[aramissennyeydd]

From a --trace-warnings, it looks like the issue is coming from

rushstack/libraries/rush-lib/src/utilities/WebClient.ts

Lines 203 to 205 in 7aa7b9f

	socket.on('error', (error: Error) => {
	reject(error);
	});

.

[iclanton]

Hmm. I wonder if these handlers need to be explicitly cleaned up. @D4N14L - care to take a look?