Feature Request: Ability to change what key/key sequence reopens or closes a profile session

[datdamnmachine]

Description of the new feature/enhancement

This feature request is related to this feature request:

#4379

Essentially, the ability to customize what key/key sequences reopens or closes a profile session. Currently Ctrl+D will close the terminal after exit and "Enter" will restart it. I would like to customize it so that "r" will restart the session and "" or "" will close the session for good. This is what MobaXterm uses and it would be nice to have it consistent as I use both regularly.

Proposed technical implementation details (optional)

Something like this in the json file:

"closeOnExit": "never",
{
"closeKey": "",
"reopenKey": "r"
}

[carlos-zamora]

Good catch! Thanks for filing this.

[skywalker290]

Can i help on this one?

[zadjii-msft]

@skywalker290 We probably won't get to this ourselves, so we'd definitely appreciate the help!

I'd caveat all this with the fact that we'll need to brainstorm what the settings would look like in the actual json, so we may change how the setting is parsed on review. I'd guess something like the following would be a good start:

    "profiles": 
    {
        "defaults": 
        {
            "closeOnExit": "never",
            "closeKey": "ctrl+alt+q",
            "reopenKey": "r"

• MTSM_PROFILE_SETTINGS in https://github.com/microsoft/terminal/blob/main/src/cascadia/TerminalSettingsModel/MTSMSettings.h#L78 already contains all the per-profile settings.
• That'd need to get plumbed down to ControlCore:

  terminal/src/cascadia/TerminalControl/ControlCore.cpp

  Lines 480 to 497 in c669afe

  	const wchar_t CtrlD = 0x4;
  	const wchar_t Enter = '\r';
  	if (_connection.State() >= winrt::Microsoft::Terminal::TerminalConnection::ConnectionState::Closed)
  	{
  	if (ch == CtrlD)
  	{
  	_CloseTerminalRequestedHandlers(*this, nullptr);
  	return true;
  	}
  	if (ch == Enter)
  	{
  	// Ask the hosting application to give us a new connection.
  	_RestartTerminalRequestedHandlers(*this, nullptr);
  	return true;
  	}
  	}

• More tricky: we'd have to find a way to also plumb those keys (or the stringification of them) into:

  terminal/src/cascadia/TerminalConnection/ConptyConnection.cpp

  Lines 457 to 470 in c669afe

  	void ConptyConnection::_indicateExitWithStatus(unsigned int status) noexcept
  	{
  	try
  	{
  	// GH#11556 - make sure to format the error code to this string as an UNSIGNED int
  	winrt::hstring exitText{ fmt::format(std::wstring_view{ RS_(L"ProcessExited") }, fmt::format(_errorFormat, status)) };
  	_TerminalOutputHandlers(L"\r\n");
  	_TerminalOutputHandlers(exitText);
  	_TerminalOutputHandlers(L"\r\n");
  	_TerminalOutputHandlers(RS_(L"CtrlDToClose"));
  	_TerminalOutputHandlers(L"\r\n");
  	}
  	CATCH_LOG();
  	}

  which is where the message is actually printed

[skywalker290]

Json format would help with this we can put data into one json structure and send it.