Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Reload/Restart Action - i.e. vscode's Reload Window #17239

Closed
g0t4 opened this issue May 10, 2024 · 5 comments
Closed

Add Reload/Restart Action - i.e. vscode's Reload Window #17239

g0t4 opened this issue May 10, 2024 · 5 comments
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting

Comments

@g0t4
Copy link

g0t4 commented May 10, 2024

Description of the new feature/enhancement

Often I find myself wanting to restart Windows Terminal, it would be nice to have a stock command/action in the Command Palette. Something similar to vscode's Developer: Reload Window

Proposed technical implementation details (optional)

Two use cases come to mind:

  • I modify settings and want to reload to ensure changes are loaded... this could be fixed via changing how settings apply to auto-reload like it used to but I assume that's not the direction settings are headed, in which case this feature becomes invaluable.
  • I modify env vars and want to ensure they are picked up. I understand there is a new setting to open new tabs/panes with the new env block and that is great, but sometimes I want to ensure all my tabs/panes have the new block in which case just killing all of them and restarting would be great.

I do not personally need to re-open tabs/panes that were closed, instead I can start with a single new tab. That said, the new option to restore pane contents when starting terminal would likely work well with a restart action.

The net effect would be to terminate (close all windows/tabs/panes) the wt.exe process and then relaunch it. Or, if there is a way to do that without killing / starting a new process that would be fine too.

@g0t4 g0t4 added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label May 10, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels May 10, 2024
Copy link

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you!

Closed similar issues:

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

@zadjii-msft
Copy link
Member

I modify settings and want to reload to ensure changes are loaded... this could be fixed via changing how settings apply to auto-reload like it used to

It still does! I suspect though what you're seeing is that when you save a fragment file, the Terminal doesn't hot-reload that. I could have swore there was an issue for that. You can just touch the main terminal settings file to have it hot-reload the fragments too.

The terminal will continue to always support hot-reloading its own settings file. I'm not about to break that any time soon 😄

I modify env vars and want to ensure they are picked up. I understand there is a new setting to open new tabs/panes with the new env block and that is great, but sometimes I want to ensure all my tabs/panes have the new block in which case just killing all of them and restarting would be great.

Oh you may be interested in the "Restart connection" action, added in 1.18, in #15241. (#3726 was this)

@g0t4
Copy link
Author

g0t4 commented May 10, 2024

@zadjii-msft I just tried what you suggested, save the main settings.json and no joe... is it possible if the file is symlinked that it might not detect changes?

@zadjii-msft
Copy link
Member

It is 1000% possible. As of #1812, that's by design.

(and it looks like #6209 treads a lot of this same ground)

@g0t4
Copy link
Author

g0t4 commented May 10, 2024

Alright, I'll close this for now then as the other issue #13416 addresses env vars.

@g0t4 g0t4 closed this as completed May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting
Projects
None yet
Development

No branches or pull requests

2 participants