Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arabic rendered as Left to Right #17904

Closed
hubaishan opened this issue Sep 11, 2024 · 7 comments
Closed

Arabic rendered as Left to Right #17904

hubaishan opened this issue Sep 11, 2024 · 7 comments
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@hubaishan
Copy link

Windows Terminal version

1.22.240823002-preview

Windows build number

10.0.19045.4529

Other Software

No response

Steps to reproduce

write Arabic text

Expected Behavior

image
from ver 1.19.11213.0 disabling "AtlasEngine"

Actual Behavior

image

@hubaishan hubaishan added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Sep 11, 2024
@lhecker
Copy link
Member

lhecker commented Sep 11, 2024

I did this intentionally so that the Arabic mode in (neo)vim would work (vim -A). For instance, using the sample text from https://r12a.github.io/scripts/arab/arb.html:

image

I was hoping to add a setting in the future which enables RTL overrides and/or detection, but I haven't gotten there yet myself.

@zadjii-msft
Copy link
Member

Probably should just bucket that with #538, yea?

@lhecker
Copy link
Member

lhecker commented Sep 23, 2024

Yeah, I'll close this as a /duplicate of #538. Thank you for the report though!

Copy link
Contributor

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@microsoft-github-policy-service microsoft-github-policy-service bot added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Sep 23, 2024
@hubaishan
Copy link
Author

Yeah, I'll close this as a /duplicate of #538. Thank you for the report though!

@lhecker these are tow different bugs this is new bug in AtlasEngine, #538 is old bug before AtlasEngine.

@DHowett
Copy link
Member

DHowett commented Sep 25, 2024

#538 tracks us actually supporting RTL text properly. It is the right issue for RTL issues because we have not officially declared support for RTL, on the old or the new renderer 😄

@lhecker
Copy link
Member

lhecker commented Sep 26, 2024

It's also worth mentioning again IMO, that I did this intentionally, so it's definitely not a bug. I did that because vim -A among others actively expects a terminal to not support RTL. I suspect it'll be easier to add RTL support once the rendering architecture has been refactored, because then AtlasEngine will be a fraction of its current size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

4 participants