Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Icon buttons to start relevant shell types #2934

Open
gdevacc12 opened this issue Sep 27, 2019 · 2 comments
Open

Feature Request: Icon buttons to start relevant shell types #2934

gdevacc12 opened this issue Sep 27, 2019 · 2 comments
Labels
Area-Extensibility A feature that would ideally be fulfilled by us having an extension model. Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal.
Milestone

Comments

@gdevacc12
Copy link

Feature request: Add icon buttons to the Windows Terminal title bar for the installed shell types (instead of the current drop down menu). Each button would start the relevant shell type. The buttons could have tool tip/mouse over for the shell type label/description.

The feature would enable one click start of the desired shell type. Currently, other than the default shell type, there's one click for the drop down, one more for the desired shell type from the list.

Then consider deprecating:

  • the + button (start default shell).
  • the drop down menu of the shell types
@gdevacc12 gdevacc12 added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Sep 27, 2019
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Sep 27, 2019
@zadjii-msft
Copy link
Member

Just to be clear, we should do this with every profile the user has?

  • Should we also add buttons for "settings", "about", "feedback"?
  • What happens when the user has 50 profiles? That's certainly a lot of buttons taking up a lot of horizontal space.
  • How would this be reconcilable with requests like Allow dropdown menu customization in profiles.json #1571, where the user wants to have nested menus?
  • how do we clearly differentiate these "new tab" buttons from tabs themselves?

I could see this as something we could hypothetically support as an extension scenario, though I dunno about doing it right in the titlebar. Might have to be a "toolbar" like browsers have for bookmarks.

Also note that you can always just use a keyboard shortcut to open a new tab with a specific profile. ctrl+shift+3 is zero clicks 😜

@zadjii-msft zadjii-msft added the Area-Extensibility A feature that would ideally be fulfilled by us having an extension model. label Sep 27, 2019
@gdevacc12
Copy link
Author

In regard to "every profile", I suggest adding a setting for each profile to show/hide the button. The default is to show the button but this can be set to hidden. This would help with 3 cases:

  1. Still allow "one click" access to the users desired "profiles"/shell types
  2. For the case of many profiles: if the user chooses they can reduce the clutter by filtering out the buttons only to their desired "frequently used" set.

Implementing the above implies the profiles in the drop down menu should NOT be deprecated, as the drop down menu list should be the full set.

Leaving the profiles in the drop down menu leaves scope to implement #1571

The menu is fine for "settings", "about", "feedback".

Considering the case of many profiles (e.g. 50):

  • Is it likely there would be so many profiles? But is so, the case is similar current state. The drop down menu would have over 50 profiles listed. I checked the current behaviour, which is the menu becomes scrollable vertically.
  • For the feature request, the buttons could similarly be in section that becomes horizontally scrollable if there are too many to display.

To differentiate to the tabs:

  • tabs are left aligned with their respective name
  • some graphical feature to separate to the buttons (e.g. minimal amount of white space)
  • buttons (to start the profile) are right aligned and without their respective name
  • to emphasise the buttons an overlayed "+" icon top right of the profile icon

The keyboard shortcuts are great for very frequent use but one must remember which profile is associated with the keyboard shortcut. An icon button has a visual prompt so not so reliant on memory.

Further considering the case for "many profiles" what keyboard shortcuts can be used for each profile?

@DHowett-MSFT DHowett-MSFT added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. labels Sep 30, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Sep 30, 2019
@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Sep 30, 2019
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone Dec 19, 2019
@zadjii-msft zadjii-msft modified the milestones: Terminal Backlog, Backlog Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Extensibility A feature that would ideally be fulfilled by us having an extension model. Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

4 participants