White border at the bottom of the window. #3064

danielniccoli · 2019-10-04T16:57:27Z

Environment

Windows build number: 10.0.18995.0
Windows Terminal version (if applicable): 0.5.2762.0

Steps to reproduce

Open Terminal app.

Expected behavior

Should not show a white border on the bottom of the window.

Actual behavior

Shows a 1 pixel thin white border on the bottom of the window.

The text was updated successfully, but these errors were encountered:

carlos-zamora · 2019-10-08T00:02:06Z

#1625? @DHowett-MSFT

sourajitk · 2019-10-13T04:08:18Z

Can confirm the existence of the issue. Occurs after the update to Windows Insider Preview.

ricardosantos9521 · 2019-10-23T10:50:38Z

It also shows a 1 pixel thin white border on the left side of the window. (build 19008)

Screen Resolution: 2256x1504, Scale: 125%:

Screen Resolution: 1920x1080, Scale: 100%:

DHowett-MSFT · 2019-10-23T20:40:14Z

Chatted with the DWM team, who owns the API we're using to control our non-client drawing. They've got a solution for us, but it'll take some time to implement.
I'm tagging this into #1625.

zadjii-msft · 2019-10-25T20:54:24Z

(We think that this is going to be closely related to a bucket of things, #3136 #1859 #3064 #1307)

AzAgarampur · 2019-11-03T01:13:27Z

@DHowett-MSFT In some of my projects, I need to use DwmExtendFrameIntoClientArea to get a window shadow. But I make my main window layered, and make the color key for the window frame transparent. I think this will solve the issue:

SetLayeredWindowAttributes(_window.get(), RGB(255, 0, 255), 0, LWA_COLORKEY);

So it would look like this:

WINRT_VERIFY(CreateWindowEx(WS_EX_LAYERED, wc.lpszClassName, L"Windows Terminal", WS_OVERLAPPEDWINDOW, CW_USEDEFAULT, CW_USEDEFAULT, CW_USEDEFAULT, CW_USEDEFAULT, nullptr, nullptr, wc.hInstance, this)); SetLayeredWindowAttributes(_window.get(), RGB(255, 0, 255), 0, LWA_COLORKEY);

Plus, you won't see the white lines at the top and bottom when resizing the window anymore.

DHowett-MSFT · 2019-11-03T01:14:58Z

@Arush-Agarampur Thanks! @greg904 actually has a comprehensive fix for this in progress in #3394.

AzAgarampur · 2019-11-03T01:20:49Z

Ahh OK, sorry I didn't see that. First time contributing to a huge project like this... 😅

We take the standard window frame except that we remove the top part (see `NonClientIslandWindow::_OnNcCalcSize`), then we put little 1 pixel wide top border back in the client area using `DwmExtendFrameIntoClientArea` and then we put the XAML island and the drag bar on top. Most of this PR is comments to explain how the code works and also removing complex code that was needed to handle the weird cases when the borders were custom. I've also refactored a little bit the `NonClientIslandWindow` class. * Fix DwmExtendFrameIntoClientArea values * Fix WM_NCHITTEST handling * Position the XAML island window correctly * Fix weird colors in drag bar and hide old title bar buttons * Fix the window's position when maximized * Add support for dark theme on the frame * DRY shared code between conhost and new terminal * Fix drag bar and remove dead code * Remove dead code and use cached DPI * Refactor code * Remove impossible TODO * Use system metrics instead of hardcoding resize border height * Use theme from app settings instead of system theme. Improve comments. Remove unused DWM frame on maximize. * Fix initial position DPI handling bug and apply review changes * Fix thick borders with DPI > 96 Closes #3064. Closes #1307. Closes #3136. Closes #1897. Closes #3222. Closes #1859.

## Summary of the Pull Request Enables the `toggleFullscreen` action to be able to enter fullscreen mode, bound by default to <kbd>alt+enter</kbd>. The action is bubbled up to the WindowsTerminal (Win32) layer, where the window resizes itself to take the entire size of the monitor. This largely reuses code from conhost. Conhost already had a fullscreen mode, so I figured I might as well re-use that. ## References Unfortunately there are still very thin borders around the window when the NonClientIslandWindow is fullscreened. I think I know where the problem is. However, that area of code is about to get a massive overhaul with #3064, so I didn't want to necessarily make it worse right now. A follow up should be filed to add support for "Always show / reveal / never show tabs in fullscreen mode". Currently, the only mode is "never show tabs". Additionally, some of this code (particularily re:drawing the nonclient area) could be re-used for #2238. ## PR Checklist * [x] Closes #531, #3411 * [x] I work here * [n/a] Tests added/passed 😭 * [x] Requires documentation to be updated ## Validation Steps Performed * Manually tested both the NonClientIslandWindow and the IslandWindow. * Cherry-pick commit 8e56bfe * Don't draw the tab strip when maximized (cherry picked from commit bac4be7) * Fix the vista window flash for the NCIW (cherry picked from commit 7d3a18a) * Some code cleanup for review (cherry picked from commit 9e22b77) * A tad bit more notes and cleanup * Update schema, docs * Most of the PR comments * I'm not sure this actually works, so I'm committing it to revert it and check * Update some comments that were lost. * Fix a build break? * oh no

ghost · 2019-11-26T17:28:29Z

🎉This issue was addressed in #3394, which has now been successfully released as Windows Terminal Preview v0.7.3291.0.:tada:

Handy links:

danielniccoli · 2019-11-27T00:06:11Z

That made the issue 4 times worse as you now have 4 white borders: top left right and bottom 😂

I think this issue needs to be reopened.

DHowett-MSFT · 2019-11-27T01:36:00Z

You're going to hate to hear this, but it's actually "by design" -- there's no official way for an application to opt in to match the shell's "dark theme" ☹️. If we trespass on those 1px borders, DWM will give up on us and force us to draw every pixel of our application. We've seen what lies at the end of that road.

saschanaz · 2019-11-27T02:04:49Z

You're going to hate to hear this (with all your effort 🙏), but could we roll it back to affect only the bottom border? 🤔

AzAgarampur · 2019-11-27T02:07:22Z

I don't want to come across as pushy, but I think the best idea is to fall back to the bottom border, and use the layered window attribute I commented earlier. It hides it perfectly, also while resizing.

DHowett-MSFT · 2019-11-27T02:39:23Z

I appreciate your input. On the balance, though: the border pull request fixed at least seven different issues (#3064, #1307, #3136, #1897, #3222, #1859, #2268; this list does not count all the ones we later realized were caused by the same thing).
I'm willing to take a one-or-two-release regression in how terminal looks--at least until we can get it ironed out--in the name of improving our project's health.

I know that it's possible to get this right (Firefox manages it, for example), but I'd rather move forward and look for the right solution than move backward and settle on the pretty bad solution we had.

DHowett-MSFT · 2019-11-27T06:04:53Z

Continuing discussion at #3425. We've figured out how to suppress the borders without using a private API. 😁

ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Oct 4, 2019

carlos-zamora added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. labels Oct 8, 2019

ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Oct 8, 2019

DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Oct 23, 2019

This was referenced Oct 23, 2019

Epic: Fix remaining issues with non-client drawing #1625

Closed

White line at the bottom of the frame in dark mode #3302

Closed

zadjii-msft added this to the Terminal-1911 milestone Oct 25, 2019

This was referenced Oct 25, 2019

Thick white border around window when showTabsInTitlebar enabled #1307

Closed

Window border width does not respect system theme #1859

Closed

Window Border expands when showTabsInTitlebar is enabled #3136

Closed

zadjii-msft assigned DHowett-MSFT Oct 25, 2019

This was referenced Nov 1, 2019

Enable fullscreen mode #3408

Merged

When in fullscreen with showTabsInTitlebar set to true, the window border is still visible #3411

Closed

beviu mentioned this issue Nov 1, 2019

Use standard 1px window borders on NC Island Window #3394

Merged

5 tasks

ghost added the In-PR This issue has a related PR label Nov 1, 2019

DHowett-MSFT closed this as completed in #3394 Nov 4, 2019

ghost added Needs-Tag-Fix Doesn't match tag requirements and removed In-PR This issue has a related PR labels Nov 4, 2019

ghost added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Nov 4, 2019

j4james mentioned this issue Nov 21, 2019

A white line appears below the mainwindow #3650

Closed

csdvrx mentioned this issue Oct 10, 2021

Thin white line or thin blue line at the bottom of the screen on Windows 11 when clicking on the Maximize button #11474

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

White border at the bottom of the window. #3064

White border at the bottom of the window. #3064

danielniccoli commented Oct 4, 2019 •

edited

Loading

carlos-zamora commented Oct 8, 2019

sourajitk commented Oct 13, 2019 •

edited

Loading

ricardosantos9521 commented Oct 23, 2019

DHowett-MSFT commented Oct 23, 2019

zadjii-msft commented Oct 25, 2019

AzAgarampur commented Nov 3, 2019 •

edited

Loading

DHowett-MSFT commented Nov 3, 2019

AzAgarampur commented Nov 3, 2019

ghost commented Nov 26, 2019

danielniccoli commented Nov 27, 2019 •

edited

Loading

DHowett-MSFT commented Nov 27, 2019 •

edited

Loading

saschanaz commented Nov 27, 2019 •

edited

Loading

AzAgarampur commented Nov 27, 2019

DHowett-MSFT commented Nov 27, 2019

DHowett-MSFT commented Nov 27, 2019

White border at the bottom of the window. #3064

White border at the bottom of the window. #3064

Comments

danielniccoli commented Oct 4, 2019 • edited Loading

Environment

Steps to reproduce

Expected behavior

Actual behavior

carlos-zamora commented Oct 8, 2019

sourajitk commented Oct 13, 2019 • edited Loading

ricardosantos9521 commented Oct 23, 2019

DHowett-MSFT commented Oct 23, 2019

zadjii-msft commented Oct 25, 2019

AzAgarampur commented Nov 3, 2019 • edited Loading

DHowett-MSFT commented Nov 3, 2019

AzAgarampur commented Nov 3, 2019

ghost commented Nov 26, 2019

danielniccoli commented Nov 27, 2019 • edited Loading

DHowett-MSFT commented Nov 27, 2019 • edited Loading

saschanaz commented Nov 27, 2019 • edited Loading

AzAgarampur commented Nov 27, 2019

DHowett-MSFT commented Nov 27, 2019

DHowett-MSFT commented Nov 27, 2019

danielniccoli commented Oct 4, 2019 •

edited

Loading

sourajitk commented Oct 13, 2019 •

edited

Loading

AzAgarampur commented Nov 3, 2019 •

edited

Loading

danielniccoli commented Nov 27, 2019 •

edited

Loading

DHowett-MSFT commented Nov 27, 2019 •

edited

Loading

saschanaz commented Nov 27, 2019 •

edited

Loading