Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProfileList support ? #3981

Closed
timiil opened this issue Dec 17, 2019 · 4 comments
Closed

ProfileList support ? #3981

timiil opened this issue Dec 17, 2019 · 4 comments
Labels
Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@timiil
Copy link

timiil commented Dec 17, 2019

do we have any plan to support ProfileList ? that can make the profiles group in the root menu,
or we just have this feature already ? i saw https://raw.githubusercontent.com/microsoft/terminal/master/doc/cascadia/profiles.schema.json had:

...
"ProfileList": {
      "description": "A list of profiles and the properties specific to each.",
      "items": {
        "$ref": "#/definitions/Profile",
        "required": [
          "guid",
          "name"
        ]
      },
      "type": "array"
    },
...

but , any sample for this ?

@timiil timiil added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Dec 17, 2019
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Dec 17, 2019
@zadjii-msft
Copy link
Member

I don't think I totally understand what you're asking for here - this is already how your settings works. You can have a list of Profile's under the profiles key in your profiles.json file:

{
    "defaultProfile": "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}",
    "profiles":
    [
        {
            "guid": "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}",
            "name": "Windows PowerShell",
            "commandline": "powershell.exe",
            "fontFace": "Cascadia Code",
            "fontSize": 14
        },
        {
            "guid": "{0caa0dad-35be-5f56-a8ff-afceeeaa6101}",
            "name": "cmd",
            "commandline": "cmd.exe",
            "fontFace": "Cascadia Code",
            "fontSize": 14
        },
        {
            "commandline" : "cmd.exe /k %CMDER_ROOT%\\vendor\\init.bat",
            "name" : "cmder",
            "startingDirectory" : "%USERPROFILE%",
            "fontFace": "Cascadia Code",
            "fontSize": 14
        }
    ]
}

You can see this doc for more details.

@timiil Could you maybe clarify what you're looking for?

@zadjii-msft zadjii-msft added Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels Dec 17, 2019
@timiil
Copy link
Author

timiil commented Dec 17, 2019

hi , i need a 'folder' ,

"profiles":
    [
        {
            
            "name": "a Good group",
            
             sub_profiles: [
                     {
            
            "name": "sub A",
            "commandline": "powershell.exe",
            "fontFace": "Cascadia Code",
            "fontSize": 14
        },
        {            
            "name": "sub B",
            "commandline": "cmd.exe",
            "fontFace": "Cascadia Code",
            "fontSize": 14
        },
             ]
        },
        {            
            "name": "another Group",
            
        },
        {
            "commandline" : "cmd.exe /k %CMDER_ROOT%\\vendor\\init.bat",
            "name" : "cmder",
            "startingDirectory" : "%USERPROFILE%",
            "fontFace": "Cascadia Code",
            "fontSize": 14
        }
    ]

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Dec 17, 2019
@zadjii-msft
Copy link
Member

@timiil Ah okay. What you're looking for is already being tracked in #1571. Thanks!

/dup #1571

@ghost
Copy link

ghost commented Dec 17, 2019

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Dec 17, 2019
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements Needs-Attention The core contributors need to come back around and look at this ASAP. labels Dec 17, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

2 participants