Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I can't delete default profiles from settings file #5055

Closed
safern opened this issue Mar 21, 2020 · 10 comments
Closed

I can't delete default profiles from settings file #5055

safern opened this issue Mar 21, 2020 · 10 comments
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@safern
Copy link
Member

safern commented Mar 21, 2020 •
edited
Loading

Environment

Windows build number:
Platform ServicePack Version      VersionString
-------- ----------- -------      -------------
 Win32NT             10.0.18363.0 Microsoft Windows NT 10.0.18363.0

Windows Terminal version (if applicable):
Version: 0.10.781.0

Steps to reproduce

Open settings file while the terminal is open.
Remove the last settings profile.
Save the file while terminal is open.
The deleted profile will be added back.

Open settings file.
Remove the last settings profile.
Close terminal.
Save settings file.
Open terminal.
The deleted profile will be added back.

Expected behavior

The settings file doesn't bring back profiles I deleted.

Actual behavior

The profiles I remove they come back when I open the terminal or if I save the file while the terminal is open.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Mar 21, 2020
@safern safern changed the title I can't delete defaults from settings file I can't delete default profiles from settings file Mar 21, 2020
@oising
Copy link
Collaborator

oising commented Mar 21, 2020

@safern Which file are you editing? defaults.json or profiles.json ?

@oising oising added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Mar 21, 2020
@jfowlie
Copy link

jfowlie commented Mar 22, 2020

I'm experiencing the same problem -- I am editing the profiles.json file and removing profiles that I don't use, but they come back immediately after closing and restarting the program. My other settings changes in that file appear to be sticking (changing the default profile, and re-ordering the profiles).

@safern
Copy link
Member Author

safern commented Mar 24, 2020

@safern Which file are you editing? defaults.json or profiles.json ?

I'm editing profiles.json. Same experience as @jfowlie above, if I change the order of profiles or add custom settings to any profile, they do stick, but when removing profiles I don't need they come back when saving if the terminal is open or when I open the terminal again.

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Mar 24, 2020
@DHowett-MSFT
Copy link
Contributor

/dup #3121 this might be an enlightening read 😄 sorry, we'll work to make sure our documentation is smarter here

@ghost
Copy link

ghost commented Mar 24, 2020

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Mar 24, 2020
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements Needs-Attention The core contributors need to come back around and look at this ASAP. labels Mar 24, 2020
@DHowett-MSFT
Copy link
Contributor

I'm sorry, I meant /dup #3231

@ghost
Copy link

ghost commented Mar 24, 2020

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@Vaskinn
Copy link

Vaskinn commented Apr 13, 2021 •
edited
Loading

@DHowett-MSFT It's problematic when bug reports are closed as duplicates of an already closed bug report that has been locked for comments. How are we supposed to provide feedback and suggestions then? I'll just do it here since it seems my best option.

I think this automatic profile generation would be a lot friendlier if the generated profile included a commentthat says something like "This profile generated by ..., to prevent it from being generated again add ... to disabledProfileSources"

@zadjii-msft
Copy link
Member

To be fair, this was resolved as a duplicate in March last year, and then the linked thread was locked in the following June, so that checks out to me.

I don't disagree that adding the comment might be helpful - though with the Settings UI getting shipped soontm, it's probably easiest to just slap something in the UI, rather than in the file itself 🤔

@Vaskinn
Copy link

Vaskinn commented Apr 13, 2021

My mistake, I didn't check the dates properly 👎

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@Vaskinn @oising @jfowlie @DHowett-MSFT @zadjii-msft @safern