-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In Solarized themes, some things aren't visible in powershell #6696
Comments
Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report! |
Thanks. Fyi, here's the commonly used ansi colors in powershell: Command "$([char]0x1b)[31m" red # 93 bright yellow
Comment "$([char]0x1b)[32m" green
ContinuationPrompt "$([char]0x1b)[37m" white # 33 yellow
DefaultToken "$([char]0x1b)[37m" white
Emphasis "$([char]0x1b)[96m" bright cyan
Error "$([char]0x1b)[91m" bright red
Keyword "$([char]0x1b)[92m" bright green
Member "$([char]0x1b)[97m" bright white
Number "$([char]0x1b)[97m" bright white
Operator "$([char]0x1b)[90m" bright black
Parameter "$([char]0x1b)[90m" bright black
Selection "$([char]0x1b)[30;47m" black on white # 35;43 magenta;yellow
String "$([char]0x1b)[36m" cyan
Type "$([char]0x1b)[37m" white
Variable "$([char]0x1b)[92m" bright green |
Maybe you should leave one of these open? People are less likely to search closed issues and pull requests. |
For anyone coming here from googling, #14859 is an ongoing issue tracker for light themes overall. |
Environment
Steps to reproduce
Set theme to Solarized Dark or Solarized Light and run Powershell.
Expected behavior
For Solarized Light, I expect to be able to see numbers and members. For Solarized Dark, I expect to be able to see operators and parameters.
Actual behavior
I cannot.
In Solarized Light, bright white is set to the same color as the background. So any token set to bright white becomes invisible. This is from get-psreadlineoptions:
In Solarized Dark, bright black is set to the same color as the background. So any token set to bright black becomes invisible. This is from get-psreadlineoptions:
A workaround for Solarized Light (console colors and ansi colors have slightly different names):
I didn't understand how the themes "redefine" colors like black, red, green, etc. This could be better explained in the docs for schemes.
The text was updated successfully, but these errors were encountered: