Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resize reflow tests #796

Open
miniksa opened this issue May 14, 2019 · 1 comment
Open

Resize reflow tests #796

miniksa opened this issue May 14, 2019 · 1 comment
Labels
Area-Interaction Interacting with the vintage console window (as opposed to driving via API or hooks) Issue-Task It's a feature request, but it doesn't really need a major design. Product-Conhost For issues in the Console codebase
Milestone
Engineering Impro...

Comments

@miniksa
Copy link
Member

miniksa commented May 14, 2019 •
edited
Loading

I have some note to myself in the internal tracker that resize-with-reflow should probably have a test suite on it. Sure, it's a conhost feature, but it will likely affect the presentation of things through the ConPTY.

We'll probably want to adjust some of the behaviors around resize-with-reflow as we tighten up integration with the PTY and with the Terminal app, and before we make big changes... we should probably have enough tests to convince ourselves that the behavior we currently have is maintained to some degree (or at least changed intentionally, not accidentally).

This was MSFT: 19600272
@miniksa miniksa added Product-Conhost For issues in the Console codebase Area-Interaction Interacting with the vintage console window (as opposed to driving via API or hooks) labels May 14, 2019
@miniksa miniksa self-assigned this May 14, 2019
@miniksa miniksa mentioned this issue May 14, 2019
Closed
@miniksa miniksa removed their assignment May 14, 2019
@miniksa miniksa mentioned this issue May 14, 2019
Closed
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label May 17, 2019
@miniksa miniksa added Issue-Task It's a feature request, but it doesn't really need a major design. and removed Mass-Chaos labels May 17, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label May 17, 2019
@zadjii-msft
Copy link
Member

Yea we probably should have some of these tests 😆

@zadjii-msft zadjii-msft mentioned this issue May 12, 2020
Open
31 tasks
@zadjii-msft zadjii-msft added this to the Engineering Improvements milestone Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Interaction Interacting with the vintage console window (as opposed to driving via API or hooks) Issue-Task It's a feature request, but it doesn't really need a major design. Product-Conhost For issues in the Console codebase
Projects
None yet
Milestone
Engineering Improvements
Development

No branches or pull requests
2 participants
@miniksa @zadjii-msft