-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add startupActions
to Settings UI
#8802
Comments
This seems a little more advanced, and a late bring-in to get into the settings UI. For it to work properly, we would need to fully parse the commandline string inside the SUI just to make sure it's valid before we let the user commit it. I don't know if we should try to push to get this into 1.6. |
@DHowett - I added the setting itself to UI, however there is an issue adding the parsed command line, as the parsing logic is a part of AppCommandlineArgs, which are is a part of TerminalApp, and thus Settings.Editor is not familiar with it. Probably we should extract the AppCommandlineArgs into a separate lib and make Editor depend on it? WDYT? |
startupActions
to Settings UI
Similar to #8755. These are settings that were added to v1.6 that need to be added to the Settings UI (or include reasoning for why not add them):
startupActions
This may not be a comprehensive list. @cinnamon-msft is verifying if any are missing and will update this issue accordingly.EDIT: verified that
startupActions
is the only one. Updating the issue title appropriately.Resources:
The text was updated successfully, but these errors were encountered: