Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a shortcut for Close Pane #993

Closed
zadjii-msft opened this issue May 24, 2019 · 5 comments · Fixed by #2012
Closed

Add a shortcut for Close Pane #993

zadjii-msft opened this issue May 24, 2019 · 5 comments · Fixed by #2012
Assignees
@zadjii-msft
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.0

Comments

@zadjii-msft
Copy link
Member

Right now the user needs to manually exit the pane.
@zadjii-msft zadjii-msft added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label May 24, 2019
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels May 24, 2019
@zadjii-msft zadjii-msft added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels May 24, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label May 24, 2019
@zadjii-msft zadjii-msft added this to the Terminal v1.0 milestone May 24, 2019
This was referenced May 24, 2019
Merged
Open
@DHowett-MSFT DHowett-MSFT removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels May 24, 2019
@varemenos
Copy link

varemenos commented Jul 14, 2019 •
edited
Loading

Doesn't that already happen with Ctrl + W? (or is a Pane not a Tab?)

@zadjii-msft
Copy link
Member Author

@varemenos Panes and Tabs are not the same thing. Tabs are the top-level entity, that may host many panes. When you open a new tab, it has one pane in it by default. This pane can be split into many panes that all occupy the same tab. Take a look at this spec for more details.

@DHowett-MSFT
Copy link
Contributor

Idea: Let's make Ctrl+W "ClosePane" by default, and closing the last pane closes the tab. Include a possibly-unbound-by-default "CloseTab". 😄

@zadjii-msft
Copy link
Member Author

Idea: Let's make Ctrl+W "ClosePane" by default, and closing the last pane closes the tab. Include a possibly-unbound-by-default "CloseTab". 😄

I like this idea SO MUCH that I'm going to do it next in my list of panes work.

zadjii-msft added a commit that referenced this issue Jul 17, 2019
@zadjii-msft
Add a keybinding for ClosePane
85285ae 
  Closes #993
  When the last pane in a tab is closed, the tab will close.
  Bound to Ctrl+Shift+W by default. See #1417 for discussion on the default
  keybindings. The Ctrl+W->CloseTab keybinding is being removed in favor of
  ClosePane.
@zadjii-msft zadjii-msft self-assigned this Jul 17, 2019
zadjii-msft added a commit that referenced this issue Jul 17, 2019
@zadjii-msft
Add a keybinding for ClosePane
27e8d00 
  Closes #993
  When the last pane in a tab is closed, the tab will close.
  Bound to Ctrl+Shift+W by default. See #1417 for discussion on the default
  keybindings. The Ctrl+W->CloseTab keybinding is being removed in favor of
  ClosePane.
@zadjii-msft zadjii-msft mentioned this issue Jul 17, 2019
Merged
4 tasks
@ghost ghost added the In-PR This issue has a related PR label Jul 17, 2019
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Jul 19, 2019
carlos-zamora pushed a commit that referenced this issue Jul 19, 2019
@zadjii-msft @carlos-zamora
Add a keybinding for ClosePane (#2012)
5074335 
Closes #993
  When the last pane in a tab is closed, the tab will close.
  Bound to Ctrl+Shift+W by default. See #1417 for discussion on the default
  keybindings. The Ctrl+W->CloseTab keybinding is being removed in favor of
  ClosePane.
mcpiroman pushed a commit to mcpiroman/terminal that referenced this issue Jul 23, 2019
@zadjii-msft @mcpiroman
Add a keybinding for ClosePane (microsoft#2012)
3d29b63 
Closes microsoft#993
  When the last pane in a tab is closed, the tab will close.
  Bound to Ctrl+Shift+W by default. See microsoft#1417 for discussion on the default
  keybindings. The Ctrl+W->CloseTab keybinding is being removed in favor of
  ClosePane.
@ghost
Copy link

ghost commented Aug 3, 2019

🎉This issue was addressed in #2012, which has now been successfully released as Windows Terminal Preview v0.3.2142.0.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zadjii-msft zadjii-msft

Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.0
Development

Successfully merging a pull request may close this issue.

Add a keybinding for ClosePane microsoft/terminal
3 participants
@varemenos @DHowett-MSFT @zadjii-msft