-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure caption controls "dim out" when window loses NC focus #10401
Conversation
Phone: 1, Code-Format Checker: 0 |
BTW, I would love some guidance on how to compile just the minimum projects necessary for testing UI changes (preferably using VS) |
अरे कोई रिव्यू कर दो |
WindowVisualStateIconified, | ||
WindowVisualStateFocused, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still pretty worried about including these in the list of window states. I think they need to be a separate enum. Here's why:
The window is always aware of its current visual state, right...
What happens if you maximize it, then un-focus it, and then focus it again?
The visual state, according to the window, is no longer "maximized." It's "focused." It totally forgot that it was maximized!
We need to track the focus state separately from whether the window is normal, maximized or iconified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I thought I had fixed that🤔, nvm, doing it asap
To test these changes, you should be building and running "CascadiaPackage" in VS. That's the project that's the complete Terminal package. |
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment. |
Smol Code
Summary of the Pull Request
Make the caption controls "dim out" when window loses focus
References
https://docs.microsoft.com/en-us/windows/win32/winmsg/wm-ncactivate
#5881
#3025
#7015
PR Checklist
Detailed Description of the Pull Request / Additional comments
Added a handler for WM_NCACTIVATE to propagate the focus change to the Titlebar Control.
The unfocused color is set to ForegroundBaseLow
Validation Steps Performed
None
(Potato™ PC, no compile)