Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add High Contrast image assets #6915

Merged
merged 1 commit into from
Jul 14, 2020
Merged

Add High Contrast image assets #6915

merged 1 commit into from
Jul 14, 2020

Conversation

jtippet
Copy link
Contributor

@jtippet jtippet commented Jul 14, 2020 •
edited
Loading

Summary of the Pull Request

Add image assets for High Contrast mode

References

Tagging this issue so it contains a nice list of all the recent HC fixes: #5360

PR Checklist

Detailed Description of the Pull Request / Additional comments

I made several changes to DHowett's script and added it to the repo:

  • Add support for generating high contrast icons
  • Add the ability to easily edit the "intermediate" (previously "zbase") files for manual hinting
  • Appease the spellcheck police

I created new SVGs for HC mode. There's one SVG for both Black and White modes -- I just invert the colors. Then I manually hinted the generated bitmaps for the production icons. I didn't bother hinting the Dev/Pre ones, so the text does get unreadable at small sizes.

Validation Steps Performed

Your web browser is probably making all these images blurry. To see how the icon really looks, save the images locally and open in mspaint.

This is the full ramp of icons:
image

Here's the terminal hanging out among a carefully-chosen taskbar full of well-behaved built-in icons:
image

Same, but at 96dpi:
image

A more typical cohort:
image

Pinned to the Start Menu:
image

@ghost ghost added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels Jul 14, 2020
zadjii-msft
zadjii-msft approved these changes Jul 14, 2020
View reviewed changes
Copy link
Member

@zadjii-msft zadjii-msft left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I'm okay with there not being a "DEV" HC Icon for now, we could file a follow-up for it.

edit: Apparently the bot doesn't listen to comments left as the review body 🤷‍♂️

@zadjii-msft
Copy link
Member

@msftbot make sure @DHowett and @cinnamon-msft sign off on this.

@ghost ghost added the AutoMerge Marked for automatic merge by the bot when requirements are met label Jul 14, 2020
@ghost
Copy link

ghost commented Jul 14, 2020

Hello @zadjii-msft!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@DHowett DHowett removed the AutoMerge Marked for automatic merge by the bot when requirements are met label Jul 14, 2020
@DHowett
Copy link
Member

DHowett commented Jul 14, 2020

This is so, so good. Thank you.

@DHowett
Copy link
Member

DHowett commented Jul 14, 2020

I'll handle the merge on this one myself, so I cleared AutoMerge

@DHowett
Copy link
Member

DHowett commented Jul 14, 2020

@jtippet Is this ready to go? I noticed you didn't mark it as closing #6822 or give it a title. I'm happy to do both, I just want to make sure

@jtippet jtippet changed the title User/jtippet/highcontrast icons Add High Contrast image assets Jul 14, 2020
@ghost ghost added Area-Accessibility Issues related to accessibility Issue-Task It's a feature request, but it doesn't really need a major design. labels Jul 14, 2020
@jtippet
Copy link
Contributor Author

jtippet commented Jul 14, 2020

@jtippet Is this ready to go? I noticed you didn't mark it as closing #6822 or give it a title. I'm happy to do both, I just want to make sure

Yeah it's ready to go... those are oversights.

@DHowett DHowett merged commit bd93cb5 into microsoft:master Jul 14, 2020
@DHowett
Copy link
Member

DHowett commented Jul 14, 2020

Thanks so much for being our HC champion

@jtippet jtippet deleted the user/jtippet/highcontrast_icons branch July 15, 2020 02:02
DHowett pushed a commit that referenced this pull request Jul 20, 2020
@jtippet @DHowett
Add High Contrast image assets (#6915)
20a6062 
This commit adds image assets for High Contrast mode

Tagging this issue so it contains a nice list of all the recent HC
fixes: #5360

I made several changes to DHowett's script and added it to the repo:
* Add support for generating high contrast icons
* Add the ability to easily edit the "intermediate" (previously "zbase")
  files for manual hinting
* Appease the spellchecker

I created new SVGs for HC mode. There's one SVG for both Black and White
modes -- I just invert the colors. Then I manually hinted the generated
bitmaps for the production icons. I didn't bother hinting the Dev/Pre
ones, so the text does get unreadable at small sizes.

View the original images in #6915.

Co-authored-by: Jeffrey Tippet <[email protected]>
Co-authored-by: Dustin L. Howett <[email protected]>
Closes #6822

(cherry picked from commit bd93cb5)
@ghost
Copy link

ghost commented Jul 21, 2020

🎉Windows Terminal v1.1.2021.0 has been released which incorporates this pull request.:tada:

Handy links:

This was referenced Jul 21, 2020
Closed
Closed
@ghost
Copy link

ghost commented Jul 22, 2020

🎉Windows Terminal v1.1.2021.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Jul 22, 2020

🎉Windows Terminal Preview v1.2.2022.0 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cinnamon-msft cinnamon-msft cinnamon-msft approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@DHowett DHowett DHowett approved these changes

Assignees
No one assigned
Labels
Area-Accessibility Issues related to accessibility Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Issue-Task It's a feature request, but it doesn't really need a major design. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

High contrast version of app icon - discussion UI is broken in system high contrast mode
4 participants
@jtippet @zadjii-msft @DHowett @cinnamon-msft