-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert TerminalSettingsEditor into a DLL #7675
Conversation
src/cascadia/TerminalSettingsEditor/TerminalSettingsEditor.vcxproj.filters
Outdated
Show resolved
Hide resolved
src/cascadia/TerminalSettingsEditor/TerminalSettingsEditor.vcxproj
Outdated
Show resolved
Hide resolved
(That's the extent of my review.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A part of me doesn't like that you replaced Microsoft.Terminal.Settings.Model
references with Microsoft.Terminal.Settings.Editor.Model
, even though I know they'll be replaced soon. Any way you can keep them as it was before? If it's too much work, I'll give up on this one.
Also want to see if we can rename the dll.
Yeah I don't like it either 😢, I still don't think it's worth the effort to keep it as It looks like to rename the dll, changing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
\azp run
Hello @leonMSFT! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
This PR's only purpose is to convert the TSE project into a DLL while getting rid of unnecessary files in the meantime, namely the `App.*` files and moving its `ResourceDictionary` into a file called `CommonResources.xaml`. In the process, I needed to move all the `Model` classes under `Editor` since it would have been a huge pain to try to add a Model dll alongside the Editor dll. I figured it also wouldn't matter too much since we'll be deleting the `Model` namespace in favor of using the incoming TSM. While this doesn't contain any code of putting the Settings UI in a tab, I figured it would be nice to push this particular part as its own standalone PR.
This PR's only purpose is to convert the TSE project into a DLL while getting rid of unnecessary files in the meantime, namely the
App.*
files and moving itsResourceDictionary
into a file calledCommonResources.xaml
.In the process, I needed to move all the
Model
classes underEditor
since it would have been a huge pain to try to add a Model dll alongside the Editor dll. I figured it also wouldn't matter too much since we'll be deleting theModel
namespace in favor of using the incoming TSM.While this doesn't contain any code of putting the Settings UI in a tab, I figured it would be nice to push this particular part as its own standalone PR.