Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide incomplete settings UI features #8078

Merged
3 commits merged into from
Oct 28, 2020
Merged

Hide incomplete settings UI features #8078

3 commits merged into from
Oct 28, 2020

Conversation

cinnamon-msft
Copy link
Contributor

Summary of the Pull Request

Removed the following from the navigation menu:

  • Search bar
  • Home page
  • Keyboard page

Changed landing page to Launch page

image

References

#1564

PR Checklist

  • Closes #xxx
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
  • Schema updated.
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

miniksa
miniksa approved these changes Oct 28, 2020
View reviewed changes
Copy link
Member

@miniksa miniksa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah OK.

carlos-zamora
carlos-zamora requested changes Oct 28, 2020
View reviewed changes
Copy link
Member

@carlos-zamora carlos-zamora left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In MainPage.cpp, we populate SearchList. Could you make sure all references to SearchList are removed?

EDIT: I'm seeing a bit of code there too that should be removed. Like AutoSuggestBox_TextChanged

EDIT2: wait, why not remove Home.xaml too? Like, we can remove some files altogether. Not just not render them.

@ghost ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Oct 28, 2020
@ghost ghost removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Oct 28, 2020
@carlos-zamora
Copy link
Member

@msftbot merge this in 5 minutes

@ghost ghost added the AutoMerge Marked for automatic merge by the bot when requirements are met label Oct 28, 2020
@ghost
Copy link

ghost commented Oct 28, 2020

Hello @carlos-zamora!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Wed, 28 Oct 2020 20:57:03 GMT, which is in 5 minutes

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@ghost ghost merged commit e2dcd16 into feature/settings-ui Oct 28, 2020
@ghost ghost deleted the cinnamon/hide-keyboard-page branch October 28, 2020 20:57
@carlos-zamora carlos-zamora mentioned this pull request Oct 28, 2020
Closed
34 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miniksa miniksa miniksa approved these changes

@carlos-zamora carlos-zamora carlos-zamora approved these changes

@DHowett DHowett DHowett approved these changes

Assignees
No one assigned
Labels
AutoMerge Marked for automatic merge by the bot when requirements are met
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cinnamon-msft @carlos-zamora @DHowett @miniksa