Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[http-client-csharp] rename UnionTypes in TypeFactory to UnionVariantTypes? #5673

Open
ArcturusZhang opened this issue Jan 21, 2025 · 0 comments
Open

[http-client-csharp] rename UnionTypes in TypeFactory to UnionVariantTypes? #5673

ArcturusZhang opened this issue Jan 21, 2025 · 0 comments
Labels
emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp

Comments

@ArcturusZhang
Copy link
Member

ArcturusZhang commented Jan 21, 2025 •
edited
Loading

We have a HashSet<string> UnionTypes in TypeFactory tracking the names of all existing union variant types.

Shall we rename it to UnionVariantTypes to avoid confusion?
@ArcturusZhang ArcturusZhang added the emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp label Jan 21, 2025
@ArcturusZhang ArcturusZhang mentioned this issue Jan 21, 2025
Draft
@ArcturusZhang ArcturusZhang changed the title [http-client-csharp] UnionTypes in TypeFactory makes no sense [http-client-csharp] rename UnionTypes in TypeFactory to UnionVariantTypes? Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ArcturusZhang