Cadl Website #935
Cadl Website #935
Conversation
|
You can try these changes at https://cadlplayground.z22.web.core.windows.net/prs/935/ Check the website changes at https://cadlwebsite.z1.web.core.windows.net/prs/935/ |
timotheeguerin
requested review from
bterlson,
daviwil,
nguerrera,
markcowl and
allenjzhang
as code owners
| operator: | ||
| /--|\+\+|\*\*=?|=>|&&=?|\|\|=?|[!=]==|<<=?|>>>?=?|[-+*/%&|^!=<>]=?|\.{3}|\?\?=?|\?\.?|[~:]/, | ||
| punctuation: /[{}[\];(),.:]/, | ||
| }; |
There was a problem hiding this comment.
I wonder if we can use the tmlanguage somehow? Seems annoying to have another set of regexes to maintain.
There was a problem hiding this comment.
Haha, yeah..., I did look if there was an existing way to auto convert it but doesn't seem like there is. Felt more work to get this to work.
There was a problem hiding this comment.
More work for sure, but I imagine we could convert to html as bicep does for its tests: https://github.com/Azure/bicep/blob/main/src/textmate/test/baselines/comments.html
And do that on publish?
There was a problem hiding this comment.
oh you mean we are the one doing the syntax highlighting instead of using the extension(via PrismJs)
There was a problem hiding this comment.
Maybe? Just brainstorming here.
There was a problem hiding this comment.
Created an issue #938
This was the PR that added bicep to PrismJS, where they seemed to have manually intepreted the tmlanguage and wrong a simple primsjs language
PrismJS/prism#3027
cleanup and improvement over the initial website implementation in #875.
Cleanup UI pieces that we don't need(at least for now).