Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash regression with completion starting with 0.30.0-insiders #5960

Closed
sean-mcmanus opened this issue Aug 12, 2020 · 3 comments
Closed

Crash regression with completion starting with 0.30.0-insiders #5960

sean-mcmanus opened this issue Aug 12, 2020 · 3 comments
Labels
bug fixed Check the Milestone for the release in which the fix is or will be available. insiders Currently only repros with our latest Insiders release. Language Service regression A bug that didn't exist in a previous release reliability Visual Studio Inherited from Visual Studio
Milestone
1.0.0

Comments

@sean-mcmanus
Copy link
Contributor

See the repro at #5864 , i.e. the code at https://pytorch.org/cppdocs/frontend.html
do completion on the "forward" of "fc1->forward".

We need to see if this repros on Windows and with VS.
@sean-mcmanus sean-mcmanus added bug reliability regression A bug that didn't exist in a previous release investigate: repro This issue's repro steps needs to be investigated/confirmed insiders Currently only repros with our latest Insiders release. labels Aug 12, 2020
@sean-mcmanus sean-mcmanus added this to the 0.30.0 milestone Aug 12, 2020
@sean-mcmanus sean-mcmanus mentioned this issue Aug 13, 2020
Closed
@sean-mcmanus sean-mcmanus mentioned this issue Sep 1, 2020
Closed
@sean-mcmanus sean-mcmanus added Visual Studio Inherited from Visual Studio and removed investigate: repro This issue's repro steps needs to be investigated/confirmed labels Sep 1, 2020
@sean-mcmanus sean-mcmanus modified the milestones: 1.0.0, Tracking Sep 1, 2020
@sean-mcmanus
Copy link
Contributor Author

I've filed VS bug https://developercommunity.visualstudio.com/content/problem/1170465/c-intellisense-crashes-from-completion-in-clang-mo.html .

@sean-mcmanus sean-mcmanus removed their assignment Sep 1, 2020
@sean-mcmanus sean-mcmanus pinned this issue Sep 1, 2020
@marco-fam
Copy link

marco-fam commented Sep 2, 2020 •
edited
Loading

I added additional comments on the issues on intellisense not working due to
"Compiler exited with error - No IL available".
Perhaps it would be helpful to add additional debug info in the cpp extension when this situation occurs.
tested with 0.30.0-insiders4!

#6009 (comment)

@sean-mcmanus
Copy link
Contributor Author

@marco-fam If you're seeing "No IL available" it is not a crash, and it most likely caused by includePath or defines not being set correctly.

@sean-mcmanus sean-mcmanus modified the milestones: Tracking, 1.0.0 Sep 3, 2020
@sean-mcmanus sean-mcmanus added the fixed Check the Milestone for the release in which the fix is or will be available. label Sep 9, 2020
@sean-mcmanus sean-mcmanus removed their assignment Sep 9, 2020
@sean-mcmanus sean-mcmanus unpinned this issue Sep 14, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug fixed Check the Milestone for the release in which the fix is or will be available. insiders Currently only repros with our latest Insiders release. Language Service regression A bug that didn't exist in a previous release reliability Visual Studio Inherited from Visual Studio
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
3 participants
@marco-fam @bobbrow @sean-mcmanus