Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certain clang-format options are not recognized #656

Closed
Vultraz opened this issue Apr 23, 2017 · 4 comments
Closed

Certain clang-format options are not recognized #656

Vultraz opened this issue Apr 23, 2017 · 4 comments
Labels
fixed Check the Milestone for the release in which the fix is or will be available. Language Service

Comments

@Vultraz
Copy link

Vultraz commented Apr 23, 2017

When running Format Document, certain options in a local clang-format config file are not recognized and cause the tool to fall back on default formatting. I've observed this with at least these:

  • SpaceAfterTemplateKeyword
  • FixNamespaceComments

I have confirmed these are valid according to the clang-format style guide. Only thing I can think of is these options are newer than the included clang-format version.

@sean-mcmanus
Copy link
Contributor

We install/use clang-format 3.8, but those options are newer. You can set the C_Cpp.clang_format_path to a newer clang-format version if you want. We were planning to update to 4.0 soon, but that version doesn't have FixNamespaceComments. Is there a specific version you wanted us to use? I don't think version 5.0 is officially released yet.

@Vultraz
Copy link
Author

Vultraz commented Apr 24, 2017

I had no specific version in mind, no. SpaceAfterTemplateKeyword is more useful to the project we're working on than FixNamespaceComments anyway.

Thanks for clearing this up :)

@sean-mcmanus sean-mcmanus added the fixed Check the Milestone for the release in which the fix is or will be available. label May 10, 2017
@bobbrow
Copy link
Member

bobbrow commented May 23, 2017

This was fixed in version 0.11.1. Please reopen if you continue to have this issue.

@bobbrow bobbrow closed this as completed May 23, 2017
@Vultraz
Copy link
Author

Vultraz commented May 23, 2017

Nope, it works fine now. Thanks :)

@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fixed Check the Milestone for the release in which the fix is or will be available. Language Service
Projects
None yet
Development

No branches or pull requests

3 participants