Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang-format does not work well #691

Closed
otsuka-kohei opened this issue May 5, 2017 · 5 comments
Closed

clang-format does not work well #691

otsuka-kohei opened this issue May 5, 2017 · 5 comments
Labels
Language Service more info needed The issue report is not actionable in its current state

Comments

@otsuka-kohei
Copy link

I write C_Cpp.clang_format_style": "{BasedOnStyle: Google,IndentWidth: 4,ColumnLimit: 0} to settings.json.
But clang-format does not format with IndentWidth option and ColumnLimit option.
clang-format by xaver works with these options.
Please fix this problem.

@sean-mcmanus
Copy link
Contributor

sean-mcmanus commented May 5, 2017

Hmm...I am not able to repro a problem on Windows and Linux. Could you give more specific details? Maybe there's some other requirement?

@sean-mcmanus sean-mcmanus added Language Service more info needed The issue report is not actionable in its current state labels May 5, 2017
@sean-mcmanus
Copy link
Contributor

sean-mcmanus commented May 5, 2017

I reviewed the code and fixed one bug which could cause this failure if there's a space before the {. Does removing any space before the { fix it?

@otsuka-kohei
Copy link
Author

Thank you response.
My settings.json does not include a space before the "{".
But I use this extesion that I can install by standard VSCode function.

@sean-mcmanus
Copy link
Contributor

I am not able to repro the bug, so I need more repro details.

@bobbrow
Copy link
Member

bobbrow commented Mar 29, 2018

Can you please try out 0.16.0 and look at the "C/C++" log channel of the Output window when your formatting fails? If you are unable to resolve your clang-format issues with the logging message, please reopen this issue and we can help you resolve it.

@bobbrow bobbrow closed this as completed Mar 29, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Language Service more info needed The issue report is not actionable in its current state
Projects
None yet
Development

No branches or pull requests

3 participants