Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide keys to color status bar working (flame symbol) #875

Closed
aeschli opened this issue Jul 11, 2017 · 8 comments
Closed

Provide keys to color status bar working (flame symbol) #875

aeschli opened this issue Jul 11, 2017 · 8 comments
Labels
bug fixed Check the Milestone for the release in which the fix is or will be available. Language Service

Comments

@aeschli
Copy link

aeschli commented Jul 11, 2017

From @ajitid on June 29, 2017 15:14

Don't know what it is called
27671023-90a1cbfe-5cae-11e7-9d7e-825f6b10825e
Are there any keys to color this?

Copied from original issue: microsoft/vscode#29873

@aeschli
Copy link
Author

aeschli commented Jul 11, 2017

From @bpasero on June 29, 2017 15:34

Currently not, these colors are provided by extensions and are not theme aware as far as I know. But I think @aeschli was thinking of giving extension authors more access to theme colors?

@aeschli
Copy link
Author

aeschli commented Jul 11, 2017

Yes, extension authors can now use one of the known theme colors, so they can be changed by users. @ajitid Do you know which extension this comes from?

@aeschli
Copy link
Author

aeschli commented Jul 11, 2017

From @ajitid on July 11, 2017 10:51

That screenshot is of C/C++ extension from Microsoft

@aeschli
Copy link
Author

aeschli commented Jul 11, 2017

Use StatusBarItem.color with a ThemeColor
https://code.visualstudio.com/docs/getstarted/theme-color-reference is the list of known theme colors.

@sean-mcmanus
Copy link
Contributor

Thanks for letting us know about this. We should have a fix soon.

@sean-mcmanus
Copy link
Contributor

sean-mcmanus commented Jul 11, 2017

@aeschli Actually, I don't see a ThemeColor that matches our desired scenario. We want a color for "busy" in the status bar -- some error color like red would work. Maybe we should change the UI to not rely on color and use some other progress indicator UI? Reworking the UI will probably not be till after our pending 0.12.1 update.

@sean-mcmanus
Copy link
Contributor

We just got rid of the color (using the default foreground), since the image conveys the meaning well enough.

@sean-mcmanus sean-mcmanus added the fixed Check the Milestone for the release in which the fix is or will be available. label Jul 11, 2017
@sean-mcmanus
Copy link
Contributor

@ajitid Fix has been released.

@sean-mcmanus sean-mcmanus removed their assignment Apr 22, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fixed Check the Milestone for the release in which the fix is or will be available. Language Service
Projects
None yet
Development

No branches or pull requests

2 participants