-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use VSCode's Workspace Trust features #2829
Comments
This probably would need to be applied to all of our tasks / launch config (debugging as a whole basically), and possibly also to Dockerfiles and docker-compose files, though I'm not sure off the top of my head what harm can be caused through them. |
Obvious ones to me: tasks, command customization, debugging |
I did some more research and it's definitely possible to leverage a malicious Dockerfile or compose document. A few examples of what could be done:
|
Info for extension authors: microsoft/vscode#120251 |
Tasks and debug are already handled by VSCode via microsoft/vscode#120251:
I think all we'll need to do is gate certain commands (via |
This has been released in Docker extension version 1.16.0. |
microsoft/vscode#106488
microsoft/vscode#120251
VSCode is adding a way to denote whether a workspace is trusted or not, and to gate features based on that. We should investigate using these APIs to increase users' security.
Features that should require a trusted workspace:
DOCKER_HOST
config (sometimes workspace, need to inspect)Note: VSCode is probably going to implement trust in such a way that any settings from untrusted workspaces are not applied, which would take care of all of these except image build / compose up.
Features that require trust (of an image, not a file) but can't be implemented since it's not files:
The text was updated successfully, but these errors were encountered: