Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SUGGESTION] There should be a way to open a solution file and not update dotnet.defaultSolution #399

Closed
jasonmalinowski opened this issue Aug 15, 2023 · 5 comments
Labels
area-solution Solution explorer enhancement New feature or request

Comments

@jasonmalinowski
Copy link
Member

Describe the feature you'd like

This is a request on behalf of @johannesergon due to their comment in dotnet/vscode-csharp#6024 (comment)

If you're somebody who works with multiple solutions in a repository, you can pick different solutions but we'll update dotnet.defaultSolution to match that. But some repositories regularly need to switch between multiple solutions, so this means we're creating a file they have to avoid checking in.

Alternatives considered

No response

Environment Information

No response

@timheuer
Copy link
Member

I believe we are changing this to be workspace specific isn't that right @lifengl ?

@lifengl
Copy link
Member

lifengl commented Sep 1, 2023

yes, that was behavior of older version of the C# Dev Kit, now it does not set defaultSolution (except a code path to create the initial solution), the session state is now saved in extension related data outside of workspace. User can set defaultSolution by hand, which would take priority, and not be overwritten by the extension.

@lifengl lifengl closed this as completed Sep 1, 2023
@Meligy
Copy link

Meligy commented Sep 5, 2023

Hello. Is this the right place to discuss / request setting multiple default solutions in a workspace?

One solution per workspace folder, chosen by the settings of this folder.

@jasonmalinowski
Copy link
Member Author

@Meligy Right repository, but it'd be good to file a new bug on that!

@Meligy
Copy link

Meligy commented Sep 6, 2023

Thanks. Added #494

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-solution Solution explorer enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants