Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impacts text/html rendering of dflib #228

Closed
maxandersen opened this issue Dec 30, 2024 · 5 comments
Closed

impacts text/html rendering of dflib #228

maxandersen opened this issue Dec 30, 2024 · 5 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug info-needed Issue requires more information from poster

Comments

@maxandersen
Copy link

in dflib/dflib#410 we've found that weirdly enough vscode-notebook-renderers somehow interfere with the echarts based text/html output.

Any idea on why vscode-notebook-renders would end up breaking/affecting text/html rendering in vscode jupyter notebooks?

@maxandersen
Copy link
Author

fwiw found that when enabling vscode-notebook-renders two nested iframes gets generated rather than just one plain iframe.

@DonJayamanne
Copy link
Contributor

Please can you provide steps to reproduce this issue with a very simple and minimal cost sample.

Also provide the list of packages that need to be installed,

@DonJayamanne DonJayamanne added bug Issue identified by VS Code Team member as probable bug info-needed Issue requires more information from poster labels Dec 30, 2024
@DonJayamanne DonJayamanne self-assigned this Dec 30, 2024
@maxandersen
Copy link
Author

there is an example here: https://github.com/jupyter-java/jupyter-java-examples/blob/main/notebooks/java-dflib-echarts.ipynb

it uses the jjava jupyter-kernel.

one simple way to set it up is to use jbang (https://www.jbang.dev/download/)

So for example:

curl -Ls https://sh.jbang.dev | bash -s - app setup
# reload terminal to have effect
jbang install-kernel@jupyter-java jjava
git clone https://github.com/jupyter-java/jupyter-java-examples
code jupyter-java-examples/notebooks/java-dflib-echarts.ipynb

then choose the jjava kernel in vscode and execute.

@DonJayamanne
Copy link
Contributor

Thank you for filing this issue, however when I disable this extension it still doesn't work for me.
I've tried this in Jupyter Lab too (without installing java or the like, as thats not required for rendering of the HTML output in the notebook).
I believe it is most likely a problem with the HTML/JS code or other.

I.e. given the fact that it already fails to load with and without the renderer extension in VS Code & also doesn't work in Jupyter Lab, its not an issue with this renderer extension. Hence closing this issue.

@DonJayamanne
Copy link
Contributor

Screenshot of this output not getting rendered in Jupyter Lab either (same empty output in vscode as well).
Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

2 participants