Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to export code to GitHub #1664

Closed
4 tasks done
joaomoreno opened this issue Apr 21, 2020 · 4 comments
Closed
4 tasks done

Support to export code to GitHub #1664

joaomoreno opened this issue Apr 21, 2020 · 4 comments
Assignees
Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@joaomoreno
Copy link
Member

joaomoreno commented Apr 21, 2020

There are a few scenarios:

  • Single folder open, no repo. Show welcome view content and status bar item to export the currently open file to a GitHub repository
  • Single folder open, repo, but no remotes. Show status bar item to export the currently open file to a GitHub repository.
  • Multi folder open, some repos with no remotes. Show status bar item to export one of the currently opened folder repos to a GitHub repository.
  • Multi folder open, no repos. Show status bar item to export one of the currently opened folder repos to a GitHub repository.
@joaomoreno joaomoreno added the feature-request Request for new features or functionality label Apr 21, 2020
@joaomoreno joaomoreno added this to the April 2020 milestone Apr 21, 2020
@joaomoreno joaomoreno self-assigned this Apr 21, 2020
@joaomoreno joaomoreno changed the title Support to export a workspace to GitHub Support to export code to GitHub Apr 21, 2020
@joaomoreno
Copy link
Member Author

joaomoreno commented Apr 24, 2020

A few considerations:

  • In order to create a repo, the user must pick between public and private, and we must present this choice properly with a warning lest they end up accidentally publishing private data to the wild. The default should be private; luckily this is now for free for everyone. 💯
  • Authentication is an issue when dealing with the git cli (git push). The auth token might be sufficient but it needs to be hooked up to the git cli. For now we prompt the user to choose between HTTPS and SSH and it's up to them to have auth properly configured in git cli. In the near future we can have a contribution mechanism in the git extension to have external authentication handlers and then have the GHPR extension be such a handler and use the token for auth in the git cli.
  • We should probably add a default .gitignore file with well known patterns... we don't want people checking in node_modules and stuff.
  • Should we add an extra step to allow to create a repo in a certain org?

@joaomoreno
Copy link
Member Author

Update:

@joaomoreno
Copy link
Member Author

Verification:

This month we added support to export a a repository to GitHub from the status bar, where the Sync action would normally be. If a repository has no remotes (multi-root or otherwise), it should still show the publish status bar icon which drives the user to export the repository to GitHub.

Additionally, when in a multi-root workspace and there are no repos, the Publish to GitHub action in the SCM welcome view should prompt the user to pick which workspace root it should publish.

@isidorn isidorn added the verified Verification succeeded label Jun 3, 2020
@isidorn
Copy link

isidorn commented Jun 3, 2020

Works great. Created one small follow up item #1852

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants