Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show a general warning prompt pointing to the upgrade guide #13716

Closed
karrtikr opened this issue Sep 1, 2020 · 1 comment
Closed

Show a general warning prompt pointing to the upgrade guide #13716

karrtikr opened this issue Sep 1, 2020 · 1 comment
Assignees
@karrtikr
Labels
area-formatting feature-request Request for new features or functionality

Comments

@karrtikr
Copy link

karrtikr commented Sep 1, 2020

Show a general warning prompt pointing to the upgrade guide, in case we see any warnings related to deprecation from isort

Look at the following warning codes to see if the message is related to deprecation: PyCQA/isort#1363 (comment)

Double check the message with Luciana:
“We found outdated configuration for sorting imports in this workspace. Check the isort upgrade guide to update your settings.”

Options:

Also, log all the warnings as errors in the output channel, otherwise won't show the warnings by default.
@karrtikr karrtikr added feature-request Request for new features or functionality needs PR area-formatting labels Sep 1, 2020
@karrtikr karrtikr self-assigned this Sep 1, 2020
@karrtikr karrtikr mentioned this issue Sep 1, 2020
Merged
10 tasks
@karrtikr
Copy link
Author

karrtikr commented Sep 1, 2020

Blocker: PyCQA/isort#1447

@karrtikr karrtikr closed this as completed Sep 3, 2020
@ghost ghost removed the needs PR label Sep 3, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@karrtikr karrtikr

Labels
area-formatting feature-request Request for new features or functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@karrtikr