Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to save extension logs to files #982

Merged
merged 27 commits into from
Apr 19, 2019
Merged

Add ability to save extension logs to files #982

merged 27 commits into from
Apr 19, 2019

Conversation

SounD120
Copy link
Contributor

@SounD120 SounD120 commented Apr 19, 2019 •
edited by vswdbot
Loading

  • Add getLoggingDirectory function that defines the directory for saving logs files if special env variables is defined
  • Add tests
    AB#477

@SounD120 SounD120 changed the title Improve extension logging Add ability to save extension logs to files Apr 19, 2019
SounD120
SounD120 commented Apr 19, 2019
View reviewed changes
test/common/log.test.ts Outdated Show resolved Hide resolved
SounD120
SounD120 commented Apr 19, 2019
View reviewed changes
test/common/log.test.ts Outdated Show resolved Hide resolved
ruslan-bikkinin
ruslan-bikkinin reviewed Apr 19, 2019
View reviewed changes
src/debugger/forkedAppWorker.ts Outdated Show resolved Hide resolved
src/debugger/forkedAppWorker.ts Outdated Show resolved Hide resolved
src/debugger/nodeDebugWrapper.ts Outdated Show resolved Hide resolved
src/extension/log/LogHelper.ts Outdated Show resolved Hide resolved
src/extension/log/LogHelper.ts Outdated Show resolved Hide resolved
test/common/log.test.ts Outdated Show resolved Hide resolved
test/common/log.test.ts Show resolved Hide resolved
test/common/log.test.ts Outdated Show resolved Hide resolved
test/common/log.test.ts Outdated Show resolved Hide resolved
test/common/log.test.ts Outdated Show resolved Hide resolved
SounD120
SounD120 commented Apr 19, 2019
View reviewed changes
test/common/log.test.ts Outdated Show resolved Hide resolved
ruslan-bikkinin
ruslan-bikkinin reviewed Apr 19, 2019
View reviewed changes
src/extension/log/LogHelper.ts Outdated Show resolved Hide resolved
src/extension/log/LogHelper.ts Outdated Show resolved Hide resolved
src/extension/log/OutputChannelLogger.ts Outdated Show resolved Hide resolved
SounD120
SounD120 commented Apr 19, 2019
View reviewed changes
test/common/log.test.ts Outdated Show resolved Hide resolved
@SounD120 SounD120 merged commit 0872226 into master Apr 19, 2019
@SounD120 SounD120 deleted the improve-extension-logging branch April 19, 2019 14:24
ruslan-bikkinin added a commit that referenced this pull request Apr 29, 2019
@ruslan-bikkinin
[Smoke tests] Implement test for running "Debug iOS" config for RN app (
3944e93 
#988)

* Update extension description (#895)

* Update sourceMapsPathOverrides string with doc path, replace `sourcemap` by `source map` (#911)

* Replace exponent with Expo (#912)

* Add tool for getting changelog for version (#917)

* Add script implementation and tests

* Fix tests

* Add real changelog testcase

* Remove debug code

* Fix lint

* Remove get-changelog tool (#919)

* Fix broken sentence (#886)

* add missing doublequotes (#924)

* Update vscode-nls-dev to the latest version for compatibility with MLCP (#930)

Fix pt-BR language tag

* Fix https://www.npmjs.com/advisories/755 (#932)

* 2019-03-12. Merged in Translation. (#933)

* 2019-03-12. Merged in Translation.

* Update command pallete translations
Fix test

* Fix ios debugging on RN 0.59 (#937)

* Add fix for rn 0.59

* Fix projectRoot, add license mentions

* Add engaging scheme from args, add tests

* Fix indent

* Update src/extension/ios/plistBuddy.ts

* Remove require

* Update src/extension/ios/plistBuddy.ts

* Prepare for 0.9.0 (#938)

* Prepare for 0.9.0

* Update changelog

* Fix "Run Android on Emulator" wording (#926)

* Add debuggerWorkerUrlPath parameter for debugger configuration (#951)

* Add tests

* Fix js-yaml vulnerability (#952)

Bump core deps

* Update docs section for running pure React Native apps via Expo (#954)

* Prepare for 0.9.1 (#959)

* Update TPN (#961)

* Update settings.json (#962)

* Added iOS simulator launch step

* Update test/smoke/src/helpers/iosSimulatorHelper.ts

Co-Authored-By: ruslan-bikkinin <[email protected]>

* Update test/smoke/src/helpers/setupEnvironmentHelper.ts

Co-Authored-By: ruslan-bikkinin <[email protected]>

* Fix siulator termination

* Fix logging for attach function (#967)

* Add information about potential problems with React Native sourcemaps (#975)

* deps: [email protected], several transitive deps (#977)

* Patch for console.trace() handler to avoid throwing error on native app (#976)

* Patch for console.trace() handler, that redefines Node.js implementation
* Add test for console.trace command
* Update node typings to node@10

* Prepare for 0.9.2 (#979)

* Add ability to save extension logs to files (#982)

* [Docs] Adding a bug to known issues in the readme for adding configuration in VSCode (#986)

* Adding a bug to known issues in the readme

* Update README.md

Co-Authored-By: springcoil <[email protected]>

* Fix known issues table (#987)

* Add Debug iOS test for RN app

* Refactor iOSSimulatorHelper

* Fix compile errors

* Update test/smoke/src/debugIos.test.ts

Co-Authored-By: ruslan-bikkinin <[email protected]>

* Make iOS version configurable

* Apply suggestions from code review

Co-Authored-By: ruslan-bikkinin <[email protected]>

* Fix some issues after review

* Update test/smoke/src/helpers/appiumHelper.ts

Co-Authored-By: ruslan-bikkinin <[email protected]>

* Fix problems running vs code during the tests
ruslan-bikkinin added a commit that referenced this pull request May 23, 2019
@ruslan-bikkinin
[Smoke Tests] Update smoke tests from master (#1013)
8b099e9 
* Update extension description (#895)

* Update sourceMapsPathOverrides string with doc path, replace `sourcemap` by `source map` (#911)

* Replace exponent with Expo (#912)

* Add tool for getting changelog for version (#917)

* Add script implementation and tests

* Fix tests

* Add real changelog testcase

* Remove debug code

* Fix lint

* Remove get-changelog tool (#919)

* Fix broken sentence (#886)

* add missing doublequotes (#924)

* Update vscode-nls-dev to the latest version for compatibility with MLCP (#930)

Fix pt-BR language tag

* Fix https://www.npmjs.com/advisories/755 (#932)

* 2019-03-12. Merged in Translation. (#933)

* 2019-03-12. Merged in Translation.

* Update command pallete translations
Fix test

* Fix ios debugging on RN 0.59 (#937)

* Add fix for rn 0.59

* Fix projectRoot, add license mentions

* Add engaging scheme from args, add tests

* Fix indent

* Update src/extension/ios/plistBuddy.ts

* Remove require

* Update src/extension/ios/plistBuddy.ts

* Prepare for 0.9.0 (#938)

* Prepare for 0.9.0

* Update changelog

* Fix "Run Android on Emulator" wording (#926)

* Add debuggerWorkerUrlPath parameter for debugger configuration (#951)

* Add tests

* Fix js-yaml vulnerability (#952)

Bump core deps

* Update docs section for running pure React Native apps via Expo (#954)

* Prepare for 0.9.1 (#959)

* Update TPN (#961)

* Update settings.json (#962)

* Fix logging for attach function (#967)

* Add information about potential problems with React Native sourcemaps (#975)

* deps: [email protected], several transitive deps (#977)

* Patch for console.trace() handler to avoid throwing error on native app (#976)

* Patch for console.trace() handler, that redefines Node.js implementation
* Add test for console.trace command
* Update node typings to node@10

* Prepare for 0.9.2 (#979)

* Add ability to save extension logs to files (#982)

* [Docs] Adding a bug to known issues in the readme for adding configuration in VSCode (#986)

* Adding a bug to known issues in the readme

* Update README.md

Co-Authored-By: springcoil <[email protected]>

* Fix known issues table (#987)

* Fix DevMenu call command for iOS (#992)

* Add check for platform for iOS platform
* Rewrite DevMenu call logic

* Fix for node debugging process arguments due to end of life of --debug-brk arg in Node 12 (#1001)

* Fix scheme parameter ambiguity (#995)

* Fix scheme parameter ambiguity

* Fix scheme parameter reading from runArguments

* Prepare for 0.9.3 (#1003)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruslan-bikkinin ruslan-bikkinin ruslan-bikkinin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SounD120 @ruslan-bikkinin