Launch the app via open cmd on macOS

[deepak1556]

Currently some users hit an issue where the app launched from command line doesn't have an active dock icon, menu and the window cannot be focused.

Thanks for help from @MarshallOfSound with the debugging we were able to narrow the source of issue. The cli wrapper is a node process which then spawns the actual app https://github.com/microsoft/vscode/blob/master/src/vs/code/node/cli.ts#L331 , this doesn't work well with entitlements. Can read for some background about inherited entitlements #95062 (comment) .

The underlying issue is not known here but we expect some sort of malformed state has been entered by the entitled app. To fix this we can adjust the spawn callsite with a call to macOS open cmd.

[bpasero]

@deepak1556 we have to be careful to still support our command line flags. Here is a simple test that fails if we switch to open:

• run alias code='open -b com.microsoft.VSCode "$@"' in terminal
• type code --list-extensions
• it fails

See also some related discussion in #60579

//cc @joaomoreno

[deepak1556]

@bpasero the open command is only meant to be used for spawning the final app executable https://github.com/microsoft/vscode/blob/master/src/vs/code/node/cli.ts#L331, it is not meant to replace the cli wrapper which respects those command line arguments.

const child = spawn('open', ['-b', 'com.microsoft.VSCode', '--args', argv], options);

[bpasero]

@deepak1556 oh I see!

[joaomoreno]

LGTM!

[segevfiner]

Might also be related to #60579

[deepak1556]

Thanks @segevfiner , definitely is related to this issue.

[memeplex]

Will this work with the --wait flag? Currently launching code with that flag produces not only recent icon duplicates but also duplicated icons in the app switcher (#112782). Neither open -b com.microsoft.VSCode --wait nor open -W -b com.microsoft.VSCode --wait work properly (even when the editor is closed, the command at the CLI keeps waiting).