Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trusted Types compatibility: use DOM API for creating HTML elements instead of string concatenation in inspectTokens.ts #105501

Closed
annkamsk opened this issue Aug 27, 2020 · 0 comments · Fixed by #105502
Closed

Trusted Types compatibility: use DOM API for creating HTML elements instead of string concatenation in inspectTokens.ts #105501

annkamsk opened this issue Aug 27, 2020 · 0 comments · Fixed by #105502
Assignees
@jrieken
Labels
engineering VS Code - Build / issue tracking / etc. insiders-released Patch has been released in VS Code Insiders
Milestone
August 2020

Comments

@annkamsk
Copy link
Contributor

The next step in resolving #103699. It aims to replace construction of HTML elements by string concatenation in src/vs/editor/standalone/browser/inspectTokens.ts file. The code contains mainly a table construction by concatenating strings of <tr><td class=”foo”>foobar</td><td class=”bar”>barfoo</td></tr>. The goal is to replace them all with dom.ts#$ function calls.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
engineering VS Code - Build / issue tracking / etc. insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Milestone
August 2020
Development

Successfully merging a pull request may close this issue.

Create HTML with dom.ts#$ function calls instead of string concatenation annkamsk/vscode
3 participants
@jrieken @annkamsk and others