We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Currently the NotebookTextModel has two sets of API
NotebookTextModel
applyEdits
Undo/Redo
insertNewCell
moveCellToIdx
removeCell
We should use applyEdits only which handles edits from all sources (multi extension host and UI) and also handle Undo/Redo.
The text was updated successfully, but these errors were encountered:
@rebornix Came to the conclusion that replaceCells is enough to represent insert and remove but not "move", right?
replaceCells
Sorry, something went wrong.
Didn't make decision yet if "move" should just a replace or stay what it is now.
replace
rebornix
jrieken
No branches or pull requests
Currently the
NotebookTextModel
has two sets of APIapplyEdits
which applies edits from the extension host currently. It supportsUndo/Redo
.insertNewCell
which handles cell insertion. It supportsUndo/Redo
.moveCellToIdx
/removeCell
handles edits from view model but doesn't handleUndo/Redo
(managed by ViewModel)We should use
applyEdits
only which handles edits from all sources (multi extension host and UI) and also handle Undo/Redo.The text was updated successfully, but these errors were encountered: