Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook Text Model Edit API debt #105523

Closed
rebornix opened this issue Aug 27, 2020 · 2 comments
Closed

Notebook Text Model Edit API debt #105523

rebornix opened this issue Aug 27, 2020 · 2 comments
Assignees
Labels
debt Code quality issues notebook

Comments

@rebornix
Copy link
Member

Currently the NotebookTextModel has two sets of API

  • applyEdits which applies edits from the extension host currently. It supports Undo/Redo.
  • insertNewCell which handles cell insertion. It supports Undo/Redo.
  • moveCellToIdx/removeCell handles edits from view model but doesn't handle Undo/Redo (managed by ViewModel)

We should use applyEdits only which handles edits from all sources (multi extension host and UI) and also handle Undo/Redo.

@rebornix rebornix added debt Code quality issues notebook labels Aug 27, 2020
@rebornix rebornix added this to the September 2020 milestone Aug 27, 2020
@rebornix rebornix mentioned this issue Aug 31, 2020
5 tasks
@jrieken
Copy link
Member

jrieken commented Sep 7, 2020

@rebornix Came to the conclusion that replaceCells is enough to represent insert and remove but not "move", right?

@rebornix
Copy link
Member Author

Didn't make decision yet if "move" should just a replace or stay what it is now.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues notebook
Projects
None yet
Development

No branches or pull requests

2 participants