Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow TextEdit to have silent flag so it won't trigger onDidChangeTextDocument #11418

Closed
drew-wallace opened this issue Sep 1, 2016 · 2 comments
Assignees
Labels
api *duplicate Issue identified as a duplicate of another issue(s)

Comments

@drew-wallace
Copy link

  • VSCode Version: 1.4.0
  • OS Version: 10.11.6
editor.edit(function (textEditorEdit) {
    return textEditorEdit.insert(position, "new silently inserted text");
}, true); // <-- silent == true

This would make my life easier for my remote pair programming app: vscode-motepair

@jrieken
Copy link
Member

jrieken commented Sep 2, 2016

This is something we won't do because it will break true listeners, think of linters et al. What we can think about is to allow you to set a source object that we pass along and you can do the filtering on your side.

@jrieken jrieken added the *duplicate Issue identified as a duplicate of another issue(s) label Sep 2, 2016
@jrieken
Copy link
Member

jrieken commented Sep 2, 2016

merge this with #10801

@jrieken jrieken closed this as completed Sep 2, 2016
vvatikiotis added a commit to vvatikiotis/vscode-pairprog that referenced this issue Sep 28, 2017
There seems to exist a infinite loop betwwen the document HasChanged
event listener and the sharedb op event hanlder. Check
microsoft/vscode#11418 and
microsoft/vscode#10801
vvatikiotis added a commit to vvatikiotis/vscode-pairprog that referenced this issue Sep 29, 2017
There seems to exist a infinite loop betwwen the document HasChanged
event listener and the sharedb op event hanlder. Check
microsoft/vscode#11418 and
microsoft/vscode#10801
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api *duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

3 participants