Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colors not consistent rendered according to theme specification #114591

Closed
PiotrSokol opened this issue Jan 19, 2021 · 1 comment
Closed

Colors not consistent rendered according to theme specification #114591

PiotrSokol opened this issue Jan 19, 2021 · 1 comment
Assignees

Comments

@PiotrSokol
Copy link

PiotrSokol commented Jan 19, 2021

Insider version

  • Version: 1.53.0-insider
  • Commit: 32b28f6
  • Date: 2021-01-19T06:10:13.886Z
  • Electron: 11.2.0
  • Chrome: 87.0.4280.141
  • Node.js: 12.18.3
  • V8: 8.7.220.31-electron.0

Regular

  • Version: 1.52.1

  • Commit: ea3859d

  • Date: 2020-12-16T16:32:10.090Z

  • Electron: 9.3.5

  • Chrome: 83.0.4103.122

  • Node.js: 12.14.1

  • V8: 8.3.110.13-electron.0

  • OS: Linux x64 5.4.0-62-generic

  • nVidia driver: 460.32.03

  • Ubuntu color space configuration: Standard RGB

The colors rendered by VSC are not consistent with the specification in any given theme.

E.g. tried out the "City Lights theme" in VSC and Atom (same author) and you can see the difference below
Steps to Reproduce:

  1. VSCode
    image

  2. Atom
    image

This holds for any theme I've tried.
Moreover, tried separately the fixes previously reported here, i.e.

	"disable-color-correct-rendering": false,
	"force-color-profile":"srgb",
	"disable-hardware-acceleration": true,

and no luck.

Does this issue occur when all extensions are disabled?: yes

@aeschli
Copy link
Contributor

aeschli commented Jan 21, 2021

This is dup of #24569.
VSCode interprets themes colors as sRGB, as used by browser, while TextMate (and probably Atom) interprets them as Apple RGB.

While we came from TextMate themes, VSCode color themes have become more than TextMate themes. We will stick with sRGB.

As a consequence, when you convert a TextMate theme to a VSCode theme and you want to be 100% color compatible, a color conversion is necessary.

@aeschli aeschli closed this as completed Jan 21, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants