Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IndexDB filesystem provider does not support file watching #117561

Closed
bpasero opened this issue Feb 24, 2021 · 3 comments
Closed

IndexDB filesystem provider does not support file watching #117561

bpasero opened this issue Feb 24, 2021 · 3 comments
Labels
*duplicate Issue identified as a duplicate of another issue(s) web Issues related to running VSCode in the web

Comments

@bpasero
Copy link
Member

bpasero commented Feb 24, 2021

It looks like the IndexDB file system provider is not able to support watching:

watch(resource: URI, opts: IWatchOptions): IDisposable {
return Disposable.None;
}

As a consequence, the storage implementation in the browser is unable to detect changes from other windows targeting global scope because it is using file watching for that purpose.

If we cannot support detecting changes from a different browser tab to the same IndexDB instance, then I think we have to close this "as designed".

//cc @sandy081

@bpasero bpasero added the web Issues related to running VSCode in the web label Feb 24, 2021
@sandy081
Copy link
Member

/duplicate

duplicate of #107854

@sandy081
Copy link
Member

More info:

It seems IndexedDB is not having an API to listen to changes done in other tabs -

Open Issue: w3c/IndexedDB#51

We need to have a workaround in our code to trigger changes.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) web Issues related to running VSCode in the web
Projects
None yet
Development

No branches or pull requests

4 participants
@bpasero @JacksonKearl @sandy081 and others