Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test External Terminal support for runInTerminal request #12252

Closed
3 tasks done
weinand opened this issue Sep 19, 2016 · 2 comments
Closed
3 tasks done

Test External Terminal support for runInTerminal request #12252

weinand opened this issue Sep 19, 2016 · 2 comments

Comments

@weinand
Copy link
Contributor

weinand commented Sep 19, 2016

Test for #11581:

Complexity 2

In this release the implementation of the 'run in external terminal' feature ("console": "externalTerminal") of node-debug has been moved to VS Code (and is now available for all debug adapters.)
A benevolent side effect of this move is that it is now possible to configure the terminal program to use via the terminal.external.windowsExec, terminal.external.osxExec, terminal.external.linuxExec settings.

Make sure that:

  • you can launch a debug target in an external terminal,
  • cwd, env vars and arguments are passed correctly,
  • you can configure a different terminal and things still work.
@octref
Copy link
Contributor

octref commented Sep 27, 2016

@weinand On linux not working for other terminals like rxvt-unicode and terminator: #12791

@octref
Copy link
Contributor

octref commented Sep 27, 2016

Also, restarting task doesn't get previous externalTerminal closed: #12793

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants