Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of wait loop in ExtHostTerminalService #12434

Closed
Tyriar opened this issue Sep 22, 2016 · 1 comment
Closed

Get rid of wait loop in ExtHostTerminalService #12434

Tyriar opened this issue Sep 22, 2016 · 1 comment
Assignees
@Tyriar
Labels
debt Code quality issues terminal General terminal issues that don't fall under another label verification-needed Verification of issue is requested verified Verification succeeded
Milestone
October 2016

Comments

@Tyriar
Copy link
Member

Tyriar commented Sep 22, 2016

#11919 (comment)
@Tyriar Tyriar added debt Code quality issues terminal General terminal issues that don't fall under another label labels Sep 22, 2016
@Tyriar Tyriar added this to the October 2016 milestone Sep 22, 2016
@Tyriar Tyriar self-assigned this Sep 22, 2016
This was referenced Sep 22, 2016
Closed
Closed
@Tyriar Tyriar closed this as completed in 611ed75 Oct 22, 2016
@Tyriar Tyriar added the verification-needed Verification of issue is requested label Oct 24, 2016
@Tyriar
Copy link
Member Author

Tyriar commented Oct 24, 2016

To verifier, please check that the extension API Terminal.processId returns the correct process ID for the shell process that is launched by VS Code.

@jrieken jrieken added the verified Verification succeeded label Oct 26, 2016
@Tyriar Tyriar reopened this Oct 26, 2016
@Tyriar Tyriar closed this as completed in 2f182c0 Oct 27, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
debt Code quality issues terminal General terminal issues that don't fall under another label verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
October 2016
Development

No branches or pull requests
2 participants
@jrieken @Tyriar