Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Commands in watermark #12607

Closed
2 tasks done
chrmarti opened this issue Sep 26, 2016 · 2 comments
Closed
2 tasks done

Test: Commands in watermark #12607

chrmarti opened this issue Sep 26, 2016 · 2 comments

Comments

@chrmarti
Copy link
Collaborator

chrmarti commented Sep 26, 2016

Test for #12534

Complexity: 2

  • Check whether or not you are shown the watermark on the empty editor area (the part of the experiment you are in)
    • Verify it stays the same when restarting (optionally: updating)
  • If shown, verify:
    • it displays correctly
    • shows the correct keybindings
    • updates when changing keybindings
  • If not shown, verify:
    • the logo displays all centered (as before)
  • Repeat with the hidden setting "telemetry.experiments.showCommandsWatermark" set to the opposite
@chrmarti chrmarti added this to the September 2016 milestone Sep 26, 2016
@chrmarti chrmarti self-assigned this Sep 26, 2016
@chrmarti chrmarti assigned jrieken and gregvanl and unassigned chrmarti Sep 27, 2016
@jrieken jrieken removed their assignment Sep 27, 2016
@gregvanl
Copy link

Suggestions #12797 and #12800

@gregvanl
Copy link

Couldn't get the telemetry.experiments.showCommandsWatermark switch to work #12807

@gregvanl gregvanl removed their assignment Sep 27, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants