Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion: add more files to integrity check #12736

Closed
bpasero opened this issue Sep 27, 2016 · 1 comment
Closed

Suggestion: add more files to integrity check #12736

bpasero opened this issue Sep 27, 2016 · 1 comment
Assignees
@alexdima
Labels
verification-needed Verification of issue is requested verified Verification succeeded
Milestone
September 2016

Comments

@bpasero
Copy link
Member

bpasero commented Sep 27, 2016

For #12659

I suggest to add vs\workbench\electron-browser\bootstrap\index.html and vs\workbench\electron-browser\bootstrap\index.js to the checks because it would make it harder for someone to inject JS/CSS into the workbench doing so.
@alexdima alexdima added this to the September 2016 milestone Sep 27, 2016
@alexdima alexdima added the verification-needed Verification of issue is requested label Sep 27, 2016
@bpasero
Copy link
Member Author

bpasero commented Sep 28, 2016

Thanks!

@bpasero bpasero added the verified Verification succeeded label Sep 28, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
September 2016
Development

No branches or pull requests
2 participants
@bpasero @alexdima