Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not use Command-ArrowDown to open an editor from a search match #12804

Closed
kieferrm opened this issue Sep 27, 2016 · 1 comment
Closed

Can not use Command-ArrowDown to open an editor from a search match #12804

kieferrm opened this issue Sep 27, 2016 · 1 comment
Assignees
Labels
invalid Issue identified as not relevant or not valid search Search widget and operation issues

Comments

@kieferrm
Copy link
Member

While testing #12519.

  • VSCode Version: 1.6.0 insiders
  • OS Version: MacOS

Steps to Reproduce:

  1. open a folder
  2. Shift+Command+F
  3. type a search expression with guaranteed matches
  4. Tab to the search results view
  5. Use ArrowDown and ArrowRight to navigate to a match
  6. Use Command-ArrowDown to open the match in an editor
    -> no editor opens
@kieferrm kieferrm added search Search widget and operation issues accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues labels Sep 27, 2016
@sandy081
Copy link
Member

sandy081 commented Oct 3, 2016

@kieferrm Command-ArrowDown is specific to open a file from the Explorer. I think it was used because Enter on a file is taken for rename in general in Mac.

In other views like Search & Problems following is supported

  • Enter opens and pins the file and highlights the result
  • Space opens the file without pinning and highlights the result

Also results displayed in these views are files, instead Search Matches or Problems.

@sandy081 sandy081 closed this as completed Oct 3, 2016
@sandy081 sandy081 added invalid Issue identified as not relevant or not valid and removed accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues labels Oct 3, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
invalid Issue identified as not relevant or not valid search Search widget and operation issues
Projects
None yet
Development

No branches or pull requests

2 participants