Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[json] no completions for enum values in alternatives #12848

Closed
kieferrm opened this issue Sep 28, 2016 · 2 comments
Closed

[json] no completions for enum values in alternatives #12848

kieferrm opened this issue Sep 28, 2016 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug json JSON support issues
Milestone

Comments

@kieferrm
Copy link
Member

Testing #12600.

  • VSCode Version: 1.6.0 insiders
  • OS Version: MacOs

Steps to Reproduce:

  1. Create the following launch.json file:
{
    "version": "0.2.0",
    "configurations": [
        {
            "name": "Launch",
            "type": "node"
        }
    ]
}
  1. in the line 6 place caret in anywhere between the quotes in "node".

  2. Ctrl+Space
    -> The only proposal you see is node. There should also be node2.

  3. delete the word node in line 6

  4. Ctrl+Space
    -> You get all valid proposal for launch config types.

@kieferrm kieferrm added the debug Debug viewlet, configurations, breakpoints, adapter issues label Sep 28, 2016
@isidorn
Copy link
Contributor

isidorn commented Sep 28, 2016

This is coming from the json schema suggest provider -> forwarding to @aeschli
Debug is properly contributing all the proposals as seen in step 5) of Kai's steps

@isidorn isidorn added bug Issue identified by VS Code Team member as probable bug json JSON support issues and removed debug Debug viewlet, configurations, breakpoints, adapter issues labels Sep 28, 2016
@isidorn isidorn assigned aeschli and unassigned weinand and isidorn Sep 28, 2016
@aeschli
Copy link
Contributor

aeschli commented Feb 1, 2017

That's a subtlety of the JSON language server implementation. In the case of alternatives for the same object (in this case a configuration for each debug adapter) code assist looks which alternative matches. As type matches 100%, it only considers the schema for that cnfiguration and ignores all others. Thats useful for all properties except for the 'type' itself...
But it's tricky and I'd rather live with the bug for now

@aeschli aeschli closed this as completed Feb 1, 2017
@aeschli aeschli changed the title Intellisense in launch.json not showing the correct proposals [json] no completions for enum values in alternatives Aug 2, 2017
@aeschli aeschli reopened this Aug 2, 2017
@aeschli aeschli added this to the Backlog milestone Aug 2, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 23, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug json JSON support issues
Projects
None yet
Development

No branches or pull requests

4 participants